Use SetNeedsBeginFrames from IPC handler
authorKevin Sawicki <kevinsawicki@gmail.com>
Tue, 20 Dec 2016 17:03:42 +0000 (09:03 -0800)
committerBirunthan Mohanathas <birunthan@mohanathas.com>
Thu, 19 Jan 2017 07:05:59 +0000 (09:05 +0200)
atom/browser/osr/osr_render_widget_host_view.cc
atom/browser/osr/osr_render_widget_host_view.h

index dea3a50971ee7c22c8787b584e9457912a4340d4..d5452a7abf36457aad95d6f848ebfcff4f2db3e1 100644 (file)
@@ -424,7 +424,7 @@ bool OffScreenRenderWidgetHostView::OnMessageReceived(
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(OffScreenRenderWidgetHostView, message)
     IPC_MESSAGE_HANDLER(ViewHostMsg_SetNeedsBeginFrames,
-                        OnSetNeedsBeginFrames)
+                        SetNeedsBeginFrames)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
@@ -548,17 +548,6 @@ bool OffScreenRenderWidgetHostView::LockMouse() {
 void OffScreenRenderWidgetHostView::UnlockMouse() {
 }
 
-void OffScreenRenderWidgetHostView::SetNeedsBeginFrames(
-    bool needs_begin_frames) {
-  SetupFrameRate(false);
-
-  begin_frame_timer_->SetActive(needs_begin_frames);
-
-  if (software_output_device_) {
-    software_output_device_->SetActive(needs_begin_frames && painting_);
-  }
-}
-
 void OffScreenRenderWidgetHostView::OnSwapCompositorFrame(
   uint32_t output_surface_id,
   cc::CompositorFrame frame) {
@@ -801,8 +790,15 @@ bool OffScreenRenderWidgetHostView::IsAutoResizeEnabled() const {
   return false;
 }
 
-void OffScreenRenderWidgetHostView::OnSetNeedsBeginFrames(bool enabled) {
-  SetNeedsBeginFrames(enabled);
+void OffScreenRenderWidgetHostView::SetNeedsBeginFrames(
+    bool needs_begin_frames) {
+  SetupFrameRate(false);
+
+  begin_frame_timer_->SetActive(needs_begin_frames);
+
+  if (software_output_device_) {
+    software_output_device_->SetActive(needs_begin_frames && painting_);
+  }
 }
 
 void OffScreenRenderWidgetHostView::OnPaint(
index 6ead7d8cf7ac181524985586b25eb126f71a48e0..ca5dae52f9de36315a1867e35f7fb2028f5a9fea 100644 (file)
@@ -175,7 +175,6 @@ class OffScreenRenderWidgetHostView
 
   bool InstallTransparency();
   bool IsAutoResizeEnabled() const;
-  void OnSetNeedsBeginFrames(bool enabled);
 
   // NativeWindowObserver:
   void OnWindowResize() override;