phy: qcom-usb-hs: Replace the extcon API
authorChanwoo Choi <cw00.choi@samsung.com>
Wed, 22 Mar 2017 10:08:37 +0000 (19:08 +0900)
committerChanwoo Choi <cwchoi00@gmail.com>
Sun, 16 Jul 2017 06:10:56 +0000 (15:10 +0900)
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- (deprecated) extcon_get_cable_state_() -> extcon_get_state()

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/phy/qualcomm/phy-qcom-usb-hs.c

index 4b20abc..2d0c70b 100644 (file)
@@ -155,12 +155,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
        }
 
        if (uphy->vbus_edev) {
-               state = extcon_get_cable_state_(uphy->vbus_edev, EXTCON_USB);
+               state = extcon_get_state(uphy->vbus_edev, EXTCON_USB);
                /* setup initial state */
                qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state,
                                              uphy->vbus_edev);
-               ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB,
-                               &uphy->vbus_notify);
+               ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev,
+                               EXTCON_USB, &uphy->vbus_notify);
                if (ret)
                        goto err_ulpi;
        }
@@ -179,16 +179,8 @@ err_sleep:
 
 static int qcom_usb_hs_phy_power_off(struct phy *phy)
 {
-       int ret;
        struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy);
 
-       if (uphy->vbus_edev) {
-               ret = extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB,
-                                                &uphy->vbus_notify);
-               if (ret)
-                       return ret;
-       }
-
        regulator_disable(uphy->v3p3);
        regulator_disable(uphy->v1p8);
        clk_disable_unprepare(uphy->sleep_clk);