projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
48c96d5
)
drm/vc4: hdmi: Fix PM reference leak in vc4_hdmi_encoder_pre_crtc_co()
author
Zou Wei
<zou_wei@huawei.com>
Mon, 24 May 2021 07:20:54 +0000
(15:20 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:44:41 +0000
(09:44 +0200)
[ Upstream commit
5e4322a8b266bc9f5ee7ea4895f661c01dbd7cb3
]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link:
https://patchwork.freedesktop.org/patch/msgid/1621840854-105978-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/vc4/vc4_hdmi.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/vc4/vc4_hdmi.c
b/drivers/gpu/drm/vc4/vc4_hdmi.c
index
25a09aa
..
6a19a3d
100644
(file)
--- a/
drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/
drivers/gpu/drm/vc4/vc4_hdmi.c
@@
-627,7
+627,7
@@
static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder)
unsigned long pixel_rate, hsm_rate;
int ret;
- ret = pm_runtime_
get_sync
(&vc4_hdmi->pdev->dev);
+ ret = pm_runtime_
resume_and_get
(&vc4_hdmi->pdev->dev);
if (ret < 0) {
DRM_ERROR("Failed to retain power domain: %d\n", ret);
return;