crypto: atmel-sha - Use devm_platform_get_and_ioremap_resource()
authorYangtao Li <frank.li@vivo.com>
Wed, 5 Jul 2023 07:21:57 +0000 (15:21 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 20 Jul 2023 10:16:25 +0000 (22:16 +1200)
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-sha.c

index 6bef634..f2031f9 100644 (file)
@@ -2604,11 +2604,9 @@ static int atmel_sha_probe(struct platform_device *pdev)
 
        crypto_init_queue(&sha_dd->queue, ATMEL_SHA_QUEUE_LENGTH);
 
-       /* Get the base address */
-       sha_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!sha_res) {
-               dev_err(dev, "no MEM resource info\n");
-               err = -ENODEV;
+       sha_dd->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, &sha_res);
+       if (IS_ERR(sha_dd->io_base)) {
+               err = PTR_ERR(sha_dd->io_base);
                goto err_tasklet_kill;
        }
        sha_dd->phys_base = sha_res->start;
@@ -2635,13 +2633,6 @@ static int atmel_sha_probe(struct platform_device *pdev)
                goto err_tasklet_kill;
        }
 
-       sha_dd->io_base = devm_ioremap_resource(&pdev->dev, sha_res);
-       if (IS_ERR(sha_dd->io_base)) {
-               dev_err(dev, "can't ioremap\n");
-               err = PTR_ERR(sha_dd->io_base);
-               goto err_tasklet_kill;
-       }
-
        err = clk_prepare(sha_dd->iclk);
        if (err)
                goto err_tasklet_kill;