scsi: ufs: avoid exception event handler racing with PM callbacks

If device raises the exception event in the response to the commands
sent during the runtime/system PM callbacks, exception event handler
might run in parallel with PM callbacks and may see unclocked register
accesses. This change fixes this issue by not scheduling the exception
event handler while PM callbacks are running.

Reviewed-by: Gilad Broner <gbroner@codeaurora.org>
Reviewed-by: Dolev Raviv <draviv@codeaurora.org>
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index e74c53a..e374b79 100644 (file)
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -3144,7 +3144,20 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
                        scsi_status = result & MASK_SCSI_STATUS;
                        result = ufshcd_scsi_cmd_status(lrbp, scsi_status);
 
-                       if (ufshcd_is_exception_event(lrbp->ucd_rsp_ptr))
+                       /*
+                        * Currently we are only supporting BKOPs exception
+                        * events hence we can ignore BKOPs exception event
+                        * during power management callbacks. BKOPs exception
+                        * event is not expected to be raised in runtime suspend
+                        * callback as it allows the urgent bkops.
+                        * During system suspend, we are anyway forcefully
+                        * disabling the bkops and if urgent bkops is needed
+                        * it will be enabled on system resume. Long term
+                        * solution could be to abort the system suspend if
+                        * UFS device needs urgent BKOPs.
+                        */
+                       if (!hba->pm_op_in_progress &&
+                           ufshcd_is_exception_event(lrbp->ucd_rsp_ptr))
                                schedule_work(&hba->eeh_work);
                        break;
                case UPIU_TRANSACTION_REJECT_UPIU: