This was originally the way this worked before before
https://reviews.llvm.org/D60882.
In retrospect it seems inconsistent that `--allow-undefined` doesn't
work for all symbols. See:
https://groups.google.com/g/emscripten-discuss/c/HSRgQiIq1gI/m/Kt9oFWHiAwAJ
I'm also planning a followup change which implement the full
`--unresolved-symbols=..` flags supported by ELF linkers (both ld and
ld.lld) since it seems more standard.
Differential Revision: https://reviews.llvm.org/D79247
; RUN: llc -filetype=obj %s -o %t.o
; RUN: not wasm-ld -o %t.wasm %t.o 2>&1 | FileCheck %s -check-prefix=UNDEF
-; RUN: not wasm-ld --allow-undefined -o %t.wasm %t.o 2>&1 | FileCheck %s -check-prefix=UNDEF
+; RUN: wasm-ld --allow-undefined -o %t.wasm %t.o
; RUN: not wasm-ld --shared -o %t.wasm %t.o 2>&1 | FileCheck %s -check-prefix=SHARED
target triple = "wasm32-unknown-unknown"
}
static bool allowUndefined(const Symbol* sym) {
- // Historically --allow-undefined doesn't work for data symbols since we don't
- // have any way to represent these as imports in the final binary. The idea
- // behind allowing undefined symbols is to allow importing these symbols from
- // the embedder and we can't do this for data symbols (at least not without
- // compiling with -fPIC)
- if (isa<DataSymbol>(sym))
- return false;
// Undefined functions with explicit import name are allowed to be undefined
// at link time.
if (auto *F = dyn_cast<UndefinedFunction>(sym))