urisourcebin: Avoid unreffing a pad we are not owning

expose_output_pad takes ownership of the pad.

diff --git a/gst/playback/gsturisourcebin.c b/gst/playback/gsturisourcebin.c
index 3e0d26db174cedc8d16b351a4df9d523db3d31b5..00162184fd2b762edefb8d2757958d9c3577d6a1 100644 (file)
--- a/gst/playback/gsturisourcebin.c
+++ b/gst/playback/gsturisourcebin.c
@@ -1454,13 +1454,16 @@ analyse_source (GstURISourceBin * urisrc, gboolean * is_raw,
             gst_object_unref (pad);
             pad = slot->srcpad;
           } else {
-            pad = create_output_pad (urisrc, pad);
+            GstPad *tmppad = create_output_pad (urisrc, pad);
+            gst_object_unref (pad);
+
+            pad = tmppad;
           }
           GST_URI_SOURCE_BIN_UNLOCK (urisrc);
           expose_output_pad (urisrc, pad);
+        } else {
           gst_object_unref (pad);
         }
-        gst_object_unref (pad);
         g_value_reset (&item);
         break;
     }