NFS: Fix a request reference leak in nfs_direct_write_clear_reqs()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 31 Mar 2020 00:13:48 +0000 (20:13 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 1 Apr 2020 17:37:56 +0000 (13:37 -0400)
nfs_direct_write_scan_commit_list() will lock the request and bump
the reference count, but we also need to account for the reference
that was taken when we initially added the request to the commit list.

Fixes: fb5f7f20cdb9 ("NFS: commit errors should be fatal")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/direct.c

index 51ab462..8074304 100644 (file)
@@ -646,6 +646,7 @@ static void nfs_direct_write_clear_reqs(struct nfs_direct_req *dreq)
        while (!list_empty(&reqs)) {
                req = nfs_list_entry(reqs.next);
                nfs_list_remove_request(req);
+               nfs_release_request(req);
                nfs_unlock_and_release_request(req);
        }
 }