projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f989065
)
iommu/vt-d: Fix sysfs leak in alloc_iommu()
author
Rolf Eike Beer
<eb@emlix.com>
Tue, 25 May 2021 07:08:02 +0000
(15:08 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 3 Jun 2021 07:00:27 +0000
(09:00 +0200)
commit
0ee74d5a48635c848c20f152d0d488bf84641304
upstream.
iommu_device_sysfs_add() is called before, so is has to be cleaned on subsequent
errors.
Fixes:
39ab9555c2411
("iommu: Add sysfs bindings for struct iommu_device")
Cc: stable@vger.kernel.org # 4.11.x
Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Link:
https://lore.kernel.org/r/17411490.HIIP88n32C@mobilepool36.emlix.com
Link:
https://lore.kernel.org/r/20210525070802.361755-2-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/intel/dmar.c
patch
|
blob
|
history
diff --git
a/drivers/iommu/intel/dmar.c
b/drivers/iommu/intel/dmar.c
index
02e7c10
..
b8d0b56
100644
(file)
--- a/
drivers/iommu/intel/dmar.c
+++ b/
drivers/iommu/intel/dmar.c
@@
-1137,7
+1137,7
@@
static int alloc_iommu(struct dmar_drhd_unit *drhd)
err = iommu_device_register(&iommu->iommu);
if (err)
- goto err_
unmap
;
+ goto err_
sysfs
;
}
drhd->iommu = iommu;
@@
-1145,6
+1145,8
@@
static int alloc_iommu(struct dmar_drhd_unit *drhd)
return 0;
+err_sysfs:
+ iommu_device_sysfs_remove(&iommu->iommu);
err_unmap:
unmap_iommu(iommu);
error_free_seq_id: