mtd: onenand: add missing check
authorjohn.maxin@nokia.com <john.maxin@nokia.com>
Fri, 6 May 2011 09:17:21 +0000 (09:17 +0000)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Wed, 25 May 2011 01:01:38 +0000 (02:01 +0100)
Coverity has reported that inside the function "onenand_block_by_block_erase()"
in onenand_base.c, we should add a check to prevent the incrementing of
possible NULL value for "region"

Signed-off-by: Maxin B. John <john.maxin@nokia.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/onenand/onenand_base.c

index d27f93b..289ee3b 100644 (file)
@@ -2453,7 +2453,7 @@ static int onenand_block_by_block_erase(struct mtd_info *mtd,
                len -= block_size;
                addr += block_size;
 
-               if (addr == region_end) {
+               if (region && addr == region_end) {
                        if (!len)
                                break;
                        region++;