block: fold blk_max_size_offset into get_max_io_size
authorChristoph Hellwig <hch@lst.de>
Tue, 14 Jun 2022 09:09:33 +0000 (11:09 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 27 Jun 2022 12:29:11 +0000 (06:29 -0600)
Now that blk_max_size_offset has a single caller left, fold it into that
and clean up the naming convention for the local variables there.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220614090934.570632-6-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-merge.c
include/linux/blkdev.h

index 4da981e..0f5f42e 100644 (file)
@@ -166,9 +166,14 @@ static inline unsigned get_max_io_size(struct request_queue *q,
 {
        unsigned pbs = queue_physical_block_size(q) >> SECTOR_SHIFT;
        unsigned lbs = queue_logical_block_size(q) >> SECTOR_SHIFT;
-       unsigned max_sectors, start, end;
+       unsigned max_sectors = queue_max_sectors(q), start, end;
+
+       if (q->limits.chunk_sectors) {
+               max_sectors = min(max_sectors,
+                       blk_chunk_sectors_left(bio->bi_iter.bi_sector,
+                                              q->limits.chunk_sectors));
+       }
 
-       max_sectors = blk_max_size_offset(q, bio->bi_iter.bi_sector, 0);
        start = bio->bi_iter.bi_sector & (pbs - 1);
        end = (start + max_sectors) & ~(pbs - 1);
        if (end > start)
index 2839612..652c357 100644 (file)
@@ -946,25 +946,6 @@ static inline unsigned int blk_chunk_sectors_left(sector_t offset,
 }
 
 /*
- * Return maximum size of a request at given offset. Only valid for
- * file system requests.
- */
-static inline unsigned int blk_max_size_offset(struct request_queue *q,
-                                              sector_t offset,
-                                              unsigned int chunk_sectors)
-{
-       if (!chunk_sectors) {
-               if (q->limits.chunk_sectors)
-                       chunk_sectors = q->limits.chunk_sectors;
-               else
-                       return q->limits.max_sectors;
-       }
-
-       return min(q->limits.max_sectors,
-                       blk_chunk_sectors_left(offset, chunk_sectors));
-}
-
-/*
  * Access functions for manipulating queue properties
  */
 extern void blk_cleanup_queue(struct request_queue *);