Revert r318704 - [Sparc] efficient pattern for UINT_TO_FP conversion

See bug https://bugs.llvm.org/show_bug.cgi?id=35631
r318704 is giving a fatal error on some code with unsigned to floating point
conversions.

llvm-svn: 320429

diff --git a/llvm/lib/Target/Sparc/SparcISelLowering.cpp b/llvm/lib/Target/Sparc/SparcISelLowering.cpp
index b355b9c5a763f0c202313cba047f491e0d6ae863..d011ec87bac1c25f0a1507122e083da9db9aafb8 100644 (file)
--- a/llvm/lib/Target/Sparc/SparcISelLowering.cpp
+++ b/llvm/lib/Target/Sparc/SparcISelLowering.cpp
@@ -1559,6 +1559,9 @@ SparcTargetLowering::SparcTargetLowering(const TargetMachine &TM,
   setOperationAction(ISD::FP_TO_UINT, MVT::i64, Custom);
   setOperationAction(ISD::UINT_TO_FP, MVT::i64, Custom);
 
+  setOperationAction(ISD::BITCAST, MVT::f32, Expand);
+  setOperationAction(ISD::BITCAST, MVT::i32, Expand);
+
   // Sparc has no select or setcc: expand to SELECT_CC.
   setOperationAction(ISD::SELECT, MVT::i32, Expand);
   setOperationAction(ISD::SELECT, MVT::f32, Expand);
@@ -1587,14 +1590,13 @@ SparcTargetLowering::SparcTargetLowering(const TargetMachine &TM,
   setOperationAction(ISD::EH_SJLJ_SETJMP, MVT::i32, Custom);
   setOperationAction(ISD::EH_SJLJ_LONGJMP, MVT::Other, Custom);
 
-  setOperationAction(ISD::BITCAST, MVT::i32, Custom);
-  setOperationAction(ISD::BITCAST, MVT::f32, Custom);
-
   if (Subtarget->is64Bit()) {
     setOperationAction(ISD::ADDC, MVT::i64, Custom);
     setOperationAction(ISD::ADDE, MVT::i64, Custom);
     setOperationAction(ISD::SUBC, MVT::i64, Custom);
     setOperationAction(ISD::SUBE, MVT::i64, Custom);
+    setOperationAction(ISD::BITCAST, MVT::f64, Expand);
+    setOperationAction(ISD::BITCAST, MVT::i64, Expand);
     setOperationAction(ISD::SELECT, MVT::i64, Expand);
     setOperationAction(ISD::SETCC, MVT::i64, Expand);
     setOperationAction(ISD::BR_CC, MVT::i64, Custom);
@@ -1608,9 +1610,6 @@ SparcTargetLowering::SparcTargetLowering(const TargetMachine &TM,
     setOperationAction(ISD::ROTL , MVT::i64, Expand);
     setOperationAction(ISD::ROTR , MVT::i64, Expand);
     setOperationAction(ISD::DYNAMIC_STACKALLOC, MVT::i64, Custom);
-
-    setOperationAction(ISD::BITCAST, MVT::i64, Custom);
-    setOperationAction(ISD::BITCAST, MVT::f64, Custom);
   }
 
   // ATOMICs.
@@ -2426,76 +2425,23 @@ static SDValue LowerFP_TO_UINT(SDValue Op, SelectionDAG &DAG,
                          1);
 }
 
-SDValue SparcTargetLowering::LowerBITCAST(SDValue Op, SelectionDAG &DAG) const {
-  SDLoc dl(Op);
-  EVT SrcVT = Op.getOperand(0).getValueType();
-
-  EVT DstVT = Op.getValueType();
-
-  if (Subtarget->isVIS3()) {
-    if (DstVT == MVT::f32 && SrcVT == MVT::i32) {
-      return Op; // Legal
-    } else if (DstVT == MVT::f64 && SrcVT == MVT::i64) {
-      return (Subtarget->is64Bit())
-                 ? Op
-                 : SDValue(); // Legal on 64 bit, otherwise Expand
-    } else if (DstVT == MVT::i64 && SrcVT == MVT::f64) {
-      return (Subtarget->is64Bit())
-                 ? Op
-                 : SDValue(); // Legal on 64 bit, otherwise Expand
-    }
-  }
-
-  // Expand
-  return SDValue();
-}
-
-SDValue SparcTargetLowering::LowerUINT_TO_FP(SDValue Op,
-                                             SelectionDAG &DAG) const {
+static SDValue LowerUINT_TO_FP(SDValue Op, SelectionDAG &DAG,
+                               const SparcTargetLowering &TLI,
+                               bool hasHardQuad) {
   SDLoc dl(Op);
   EVT OpVT = Op.getOperand(0).getValueType();
   assert(OpVT == MVT::i32 || OpVT == MVT::i64);
 
-  // Expand f128 operations to fp128 ABI calls.
-  if (Op.getValueType() == MVT::f128 &&
-      (!Subtarget->hasHardQuad() || !isTypeLegal(OpVT))) {
-    return LowerF128Op(Op, DAG,
-                       getLibcallName(OpVT == MVT::i32
-                                          ? RTLIB::UINTTOFP_I32_F128
-                                          : RTLIB::UINTTOFP_I64_F128),
-                       1);
-  }
-
-  // Since UINT_TO_FP is legal (it's marked custom), dag combiner won't
-  // optimize it to a SINT_TO_FP when the sign bit is known zero. Perform
-  // the optimization here.
-  if (DAG.SignBitIsZero(Op.getOperand(0))) {
-
-    EVT floatVT = MVT::f32;
-    unsigned IntToFloatOpcode = SPISD::ITOF;
-
-    if (OpVT == MVT::i64) {
-      floatVT = MVT::f64;
-      IntToFloatOpcode = SPISD::XTOF;
-    }
-
-    // Convert the int value to FP in an FP register.
-    SDValue FloatTmp = DAG.getNode(ISD::BITCAST, dl, floatVT, Op.getOperand(0));
-
-    return DAG.getNode(IntToFloatOpcode, dl, Op.getValueType(), FloatTmp);
-  }
-
-  if (OpVT == MVT::i32 && Subtarget->is64Bit()) {
-
-    SDValue Int64Tmp =
-        DAG.getNode(ISD::ZERO_EXTEND, dl, MVT::i64, Op.getOperand(0));
-
-    SDValue Float64Tmp = DAG.getNode(ISD::BITCAST, dl, MVT::f64, Int64Tmp);
-
-    return DAG.getNode(SPISD::XTOF, dl, Op.getValueType(), Float64Tmp);
-  }
+  // Expand if it does not involve f128 or the target has support for
+  // quad floating point instructions and the operand type is legal.
+  if (Op.getValueType() != MVT::f128 || (hasHardQuad && TLI.isTypeLegal(OpVT)))
+    return SDValue();
 
-  return SDValue();
+  return TLI.LowerF128Op(Op, DAG,
+                         TLI.getLibcallName(OpVT == MVT::i32
+                                            ? RTLIB::UINTTOFP_I32_F128
+                                            : RTLIB::UINTTOFP_I64_F128),
+                         1);
 }
 
 static SDValue LowerBR_CC(SDValue Op, SelectionDAG &DAG,
@@ -3113,7 +3059,8 @@ LowerOperation(SDValue Op, SelectionDAG &DAG) const {
                                                        hasHardQuad);
   case ISD::FP_TO_UINT:         return LowerFP_TO_UINT(Op, DAG, *this,
                                                        hasHardQuad);
-  case ISD::UINT_TO_FP:         return LowerUINT_TO_FP(Op, DAG);
+  case ISD::UINT_TO_FP:         return LowerUINT_TO_FP(Op, DAG, *this,
+                                                       hasHardQuad);
   case ISD::BR_CC:              return LowerBR_CC(Op, DAG, *this,
                                                   hasHardQuad);
   case ISD::SELECT_CC:          return LowerSELECT_CC(Op, DAG, *this,
@@ -3150,7 +3097,6 @@ LowerOperation(SDValue Op, SelectionDAG &DAG) const {
   case ISD::ATOMIC_LOAD:
   case ISD::ATOMIC_STORE:       return LowerATOMIC_LOAD_STORE(Op, DAG);
   case ISD::INTRINSIC_WO_CHAIN: return LowerINTRINSIC_WO_CHAIN(Op, DAG);
-  case ISD::BITCAST:            return LowerBITCAST(Op, DAG);
   }
 }
 

diff --git a/llvm/lib/Target/Sparc/SparcISelLowering.h b/llvm/lib/Target/Sparc/SparcISelLowering.h
index 501e16dc2d96693151708a0e1722ef4c592b9d3d..bf700d6a99d8b5f6c95e6988e86a48870e4e01ba 100644 (file)
--- a/llvm/lib/Target/Sparc/SparcISelLowering.h
+++ b/llvm/lib/Target/Sparc/SparcISelLowering.h
@@ -192,10 +192,6 @@ namespace llvm {
 
     SDValue LowerINTRINSIC_WO_CHAIN(SDValue Op, SelectionDAG &DAG) const;
 
-    SDValue LowerBITCAST(SDValue Op, SelectionDAG &DAG) const;
-
-    SDValue LowerUINT_TO_FP(SDValue Op, SelectionDAG &DAG) const;
-
     bool ShouldShrinkFPConstant(EVT VT) const override {
       // Do not shrink FP constpool if VT == MVT::f128.
       // (ldd, call _Q_fdtoq) is more expensive than two ldds.

diff --git a/llvm/lib/Target/Sparc/SparcInstrVIS.td b/llvm/lib/Target/Sparc/SparcInstrVIS.td
index dc3aa45bedc93b089578cfc9dac7ceb0282dfcba..d9adf3e8b0f52cbf34c104ba41e10a6d5bc85a52 100644 (file)
--- a/llvm/lib/Target/Sparc/SparcInstrVIS.td
+++ b/llvm/lib/Target/Sparc/SparcInstrVIS.td
@@ -243,21 +243,16 @@ def LZCNT     : VISInstFormat<0b000010111, (outs I64Regs:$rd),
                    (ins I64Regs:$rs2), "lzcnt $rs2, $rd", []>;
 
 let rs1 = 0 in {
-def MOVSTOSW : VISInstFormat<0b100010011, (outs I64Regs:$rd), (ins FPRegs:$rs2), 
-                   "movstosw $rs2, $rd", 
-                   [(set I64Regs:$rd, (sext (i32 (bitconvert FPRegs:$rs2))))]>;
-def MOVSTOUW : VISInstFormat<0b100010001, (outs I64Regs:$rd), (ins FPRegs:$rs2), 
-                   "movstouw $rs2, $rd", 
-                   [(set I64Regs:$rd, (zext (i32 (bitconvert FPRegs:$rs2))))]>;
-def MOVDTOX  : VISInstFormat<0b100010000, (outs I64Regs:$rd), (ins DFPRegs:$rs2), 
-                   "movdtox $rs2, $rd", 
-                   [(set I64Regs:$rd, (bitconvert DFPRegs:$rs2))]>;
-def MOVWTOS  :  VISInstFormat<0b100011001, (outs FPRegs:$rd), (ins IntRegs:$rs2), 
-                   "movwtos $rs2, $rd", 
-                   [(set FPRegs:$rd, (bitconvert i32:$rs2))]>;
-def MOVXTOD  :  VISInstFormat<0b100011000, (outs DFPRegs:$rd), (ins I64Regs:$rs2),
-                   "movxtod $rs2, $rd", 
-                   [(set DFPRegs:$rd, (bitconvert I64Regs:$rs2))]>;
+def MOVSTOSW : VISInstFormat<0b100010011, (outs I64Regs:$rd),
+                   (ins DFPRegs:$rs2), "movstosw $rs2, $rd", []>;
+def MOVSTOUW : VISInstFormat<0b100010001, (outs I64Regs:$rd),
+                   (ins DFPRegs:$rs2), "movstouw $rs2, $rd", []>;
+def MOVDTOX  : VISInstFormat<0b100010000, (outs I64Regs:$rd),
+                   (ins DFPRegs:$rs2), "movdtox $rs2, $rd", []>;
+def MOVWTOS  :  VISInstFormat<0b100011001, (outs DFPRegs:$rd),
+                   (ins I64Regs:$rs2), "movdtox $rs2, $rd", []>;
+def MOVXTOD  :  VISInstFormat<0b100011000, (outs DFPRegs:$rd),
+                   (ins I64Regs:$rs2), "movdtox $rs2, $rd", []>;
 }
 
 def PDISTN   : VISInst<0b000111111, "pdistn">;

diff --git a/llvm/test/CodeGen/SPARC/float.ll b/llvm/test/CodeGen/SPARC/float.ll
index b8ece417044a2eced2074b0b6bd7447963868069..248e98549c9f7d92847862a176609a3ae35a2f38 100644 (file)
--- a/llvm/test/CodeGen/SPARC/float.ll
+++ b/llvm/test/CodeGen/SPARC/float.ll
@@ -3,8 +3,6 @@
 ; RUN: llc -march=sparc -O0 < %s | FileCheck %s -check-prefix=V8-UNOPT
 ; RUN: llc -march=sparc -mattr=v9 < %s | FileCheck %s -check-prefix=V9
 ; RUN: llc -mtriple=sparc64-unknown-linux < %s | FileCheck %s -check-prefix=SPARC64
-; RUN: llc -march=sparc -mcpu=niagara4 < %s  | FileCheck %s -check-prefix=VIS3
-; RUN: llc -march=sparcv9 -mcpu=niagara4 < %s | FileCheck %s -check-prefix=VIS3-64
 
 ; V8-LABEL:     test_neg:
 ; V8:     call get_double
@@ -196,7 +194,7 @@ entry:
 ; V9:          fstoi
 
 ; SPARC64-LABEL:    test_utos_stou
-; SPARC64:     fxtos
+; SPARC64:     fdtos
 ; SPARC64:     fstoi
 
 define void @test_utos_stou(i32 %a, i32* %ptr0, float* %ptr1) {
@@ -242,9 +240,6 @@ entry:
 ; SPARC64-NOT:      fitod
 ; SPARC64:          fdtoi
 
-; VIS3-64-LABEL:  test_utod_dtou
-; VIS3-64:        movxtod 
-
 define void @test_utod_dtou(i32 %a, double %b, i32* %ptr0, double* %ptr1) {
 entry:
   %0 = uitofp i32 %a to double
@@ -253,49 +248,3 @@ entry:
   store i32 %1, i32* %ptr0, align 8
   ret void
 }
-
-; V8-LABEL:    test_ustod
-; V8:          fitod
-
-; VIS3-LABEL:  test_ustod
-; VIS3:        movwtos 
-
-define double @test_ustod(i16 zeroext) {
-  %2 = uitofp i16 %0 to double
-  ret double %2
-}
-
-; V8-LABEL:    test_ustos
-; V8:          fitos
-
-; VIS3-LABEL:  test_ustos
-; VIS3:        movwtos
-
-define float @test_ustos(i16 zeroext) {
-  %2 = uitofp i16 %0 to float 
-  ret float %2
-}
-
-; check for movwtos used for bitcast 
-;
-; VIS3-LABEL:  test_bitcast_utos 
-; VIS3:movwtos  
-
-define float @test_bitcast_utos(i32 ) {
-  %2 = bitcast i32 %0 to float 
-  ret float %2
-}
-
-
-; check for movxtod used for bitcast 
-;
-; VIS3-64-LABEL:  test_bitcast_uxtod 
-; VIS3-64:movxtod  
-
-define double @test_bitcast_uxtod(i64 ) {
-  %2 = bitcast i64 %0 to double 
-  ret double %2
-}
-
-
-