[chromium] Fix compiler warning in CCSchedulerTest.cpp with gcc 4.6.3
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 28 Apr 2012 02:29:26 +0000 (02:29 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 28 Apr 2012 02:29:26 +0000 (02:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=85110

Reviewed by James Robinson.

Using gcc 4.6.3 (default on Precise), I get:
third_party/WebKit/Source/WebKit/chromium/tests/CCSchedulerTest.cpp:188:5: error: converting 'false' to pointer type
for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]

* tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/tests/CCSchedulerTest.cpp

index 38eb41b..55b3eff 100644 (file)
@@ -1,3 +1,17 @@
+2012-04-27  Tony Chang  <tony@chromium.org>
+
+        [chromium] Fix compiler warning in CCSchedulerTest.cpp with gcc 4.6.3
+        https://bugs.webkit.org/show_bug.cgi?id=85110
+
+        Reviewed by James Robinson.
+
+        Using gcc 4.6.3 (default on Precise), I get:
+        third_party/WebKit/Source/WebKit/chromium/tests/CCSchedulerTest.cpp:188:5: error: converting 'false' to pointer type
+        for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
+
+        * tests/CCSchedulerTest.cpp:
+        (WebKitTests::TEST):
+
 2012-04-27  Nat Duca  <nduca@chromium.org>
 
         Expose high-resolution on requestAnimationFrame callback
index 5730a4f..4125088 100644 (file)
@@ -185,11 +185,11 @@ TEST(CCSchedulerTest, TextureAcquisitionCollision)
     client.reset();
 
     // Compositor not scheduled to draw because textures are locked by main thread
-    EXPECT_EQ(false, timeSource->active());
+    EXPECT_FALSE(timeSource->active());
 
     // Trigger the commit
     scheduler->beginFrameComplete();
-    EXPECT_EQ(true, timeSource->active());
+    EXPECT_TRUE(timeSource->active());
     client.reset();
 
     // Between commit and draw, texture acquisition for main thread delayed,