Remove wrong unref of sevice->pending
authorMartin Xu <martin.xu@intel.com>
Tue, 9 Feb 2010 09:29:52 +0000 (10:29 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 11 Feb 2010 04:29:51 +0000 (05:29 +0100)
When setting static ip for ethernet service, unreferencing service->pending
here will cause a segmentation fault.

The reason is that it is done in __connman_service_indicate_state() when
connection succeeds, and service->pending is NULL.

src/service.c

index eb1402a..8f52fc0 100644 (file)
@@ -1062,9 +1062,6 @@ static DBusMessage *connect_service(DBusConnection *conn,
                return NULL;
        }
 
-       dbus_message_unref(service->pending);
-       service->pending = NULL;
-
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }