hw/xwin: Make sure that WM_WM_HINTS_EVENT does nothing for override-redirect windows
authorJon TURNEY <jon.turney@dronecode.org.uk>
Sat, 31 Mar 2012 17:45:28 +0000 (18:45 +0100)
committerJon TURNEY <jon.turney@dronecode.org.uk>
Wed, 16 Jan 2013 16:49:56 +0000 (16:49 +0000)
Future work: It looks like this code could be rationalized quite a lot: It might
make sense to pull the checking for override-redirect up out of UpdateIcon() and
UpdateName() and consolidate WM_WM_MAP2 and WM_WM_MAP3

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Colin Harrison <colin.harrison@virgin.net>
hw/xwin/winmultiwindowwm.c

index 1200243..1dc31fd 100644 (file)
@@ -817,6 +817,12 @@ winMultiWindowWMProc(void *pArg)
             {
             HWND zstyle = HWND_NOTOPMOST;
             UINT flags;
+            XWindowAttributes attr;
+
+            /* Don't do anything if this is an override-redirect window */
+            XGetWindowAttributes (pWMInfo->pDisplay, pNode->msg.iWindow, &attr);
+            if (attr.override_redirect)
+              break;
 
             pNode->msg.hwndWindow = getHwnd(pWMInfo, pNode->msg.iWindow);