ext4: remove redundant variable has_bigalloc in ext4_fill_super
authorKaixu Xia <kaixuxia@tencent.com>
Wed, 15 Apr 2020 07:25:42 +0000 (15:25 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 14 May 2020 14:40:11 +0000 (10:40 -0400)
We can use the ext4_has_feature_bigalloc() function directly to check
bigalloc feature and the variable has_bigalloc is reduncant, so remove
it.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/1586935542-29588-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c

index 79e07e6..49821d8 100644 (file)
@@ -3679,7 +3679,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
        int blocksize, clustersize;
        unsigned int db_count;
        unsigned int i;
-       int needs_recovery, has_huge_files, has_bigalloc;
+       int needs_recovery, has_huge_files;
        __u64 blocks_count;
        int err = 0;
        unsigned int journal_ioprio = DEFAULT_JOURNAL_IOPRIO;
@@ -4194,8 +4194,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 
        /* Handle clustersize */
        clustersize = BLOCK_SIZE << le32_to_cpu(es->s_log_cluster_size);
-       has_bigalloc = ext4_has_feature_bigalloc(sb);
-       if (has_bigalloc) {
+       if (ext4_has_feature_bigalloc(sb)) {
                if (clustersize < blocksize) {
                        ext4_msg(sb, KERN_ERR,
                                 "cluster size (%d) smaller than "