drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE
authorQinglang Miao <miaoqinglang@huawei.com>
Thu, 17 Sep 2020 12:39:49 +0000 (20:39 +0800)
committerLiviu Dudau <liviu.dudau@arm.com>
Fri, 23 Oct 2020 12:52:15 +0000 (13:52 +0100)
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Tested-by: Carsten Haitzler <carsten.haitzler@foss.arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200917123949.101925-1-miaoqinglang@huawei.com
drivers/gpu/drm/arm/display/komeda/komeda_dev.c

index 0398021..1f8195b 100644 (file)
@@ -41,18 +41,7 @@ static int komeda_register_show(struct seq_file *sf, void *x)
        return 0;
 }
 
-static int komeda_register_open(struct inode *inode, struct file *filp)
-{
-       return single_open(filp, komeda_register_show, inode->i_private);
-}
-
-static const struct file_operations komeda_register_fops = {
-       .owner          = THIS_MODULE,
-       .open           = komeda_register_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(komeda_register);
 
 #ifdef CONFIG_DEBUG_FS
 static void komeda_debugfs_init(struct komeda_dev *mdev)