tools: gpio: fix spurious close warning in lsgpio
authorKent Gibson <warthog618@gmail.com>
Wed, 8 Jul 2020 04:15:58 +0000 (12:15 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Sun, 12 Jul 2020 08:22:01 +0000 (10:22 +0200)
Fix bogus close warning that occurs when opening the character device
fails.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
tools/gpio/lsgpio.c

index 8a71ad3..b08d7a5 100644 (file)
@@ -94,7 +94,7 @@ int list_device(const char *device_name)
        if (fd == -1) {
                ret = -errno;
                fprintf(stderr, "Failed to open %s\n", chrdev_name);
-               goto exit_close_error;
+               goto exit_free_name;
        }
 
        /* Inspect this GPIO chip */
@@ -141,6 +141,7 @@ int list_device(const char *device_name)
 exit_close_error:
        if (close(fd) == -1)
                perror("Failed to close GPIO character device file");
+exit_free_name:
        free(chrdev_name);
        return ret;
 }