blk-mq: fix redundant check of !e expression
authorJean Sacren <sakiwit@gmail.com>
Fri, 29 Oct 2021 20:29:45 +0000 (14:29 -0600)
committerJens Axboe <axboe@kernel.dk>
Sat, 30 Oct 2021 15:34:14 +0000 (09:34 -0600)
In the if branch, e is checked.  In the else branch, ->dispatch_busy is
merely a number and has no effect on !e.  We should remove the check of
!e since it is always true.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Link: https://lore.kernel.org/r/20211029202945.3052-1-sakiwit@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-sched.c

index c62b966..4a6789e 100644 (file)
@@ -497,7 +497,7 @@ void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx,
                 * busy in case of 'none' scheduler, and this way may save
                 * us one extra enqueue & dequeue to sw queue.
                 */
-               if (!hctx->dispatch_busy && !e && !run_queue_async) {
+               if (!hctx->dispatch_busy && !run_queue_async) {
                        blk_mq_try_issue_list_directly(hctx, list);
                        if (list_empty(list))
                                goto out;