KVM: x86 emulator: set RFLAGS outside x86 emulator code

Removes the need for set_flags() callback.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h
index b7e00cb..a87d95f 100644 (file)
--- a/arch/x86/include/asm/kvm_emulate.h
+++ b/arch/x86/include/asm/kvm_emulate.h
@@ -142,7 +142,6 @@ struct x86_emulate_ops {
        ulong (*get_cr)(int cr, struct kvm_vcpu *vcpu);
        int (*set_cr)(int cr, ulong val, struct kvm_vcpu *vcpu);
        int (*cpl)(struct kvm_vcpu *vcpu);
-       void (*set_rflags)(struct kvm_vcpu *vcpu, unsigned long rflags);
        int (*get_dr)(int dr, unsigned long *dest, struct kvm_vcpu *vcpu);
        int (*set_dr)(int dr, unsigned long value, struct kvm_vcpu *vcpu);
        int (*set_msr)(struct kvm_vcpu *vcpu, u32 msr_index, u64 data);

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 437f31b..291e220 100644 (file)
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -3034,7 +3034,6 @@ writeback:
        /* Commit shadow register state. */
        memcpy(ctxt->vcpu->arch.regs, c->regs, sizeof c->regs);
        ctxt->eip = c->eip;
-       ops->set_rflags(ctxt->vcpu, ctxt->eflags);
 
 done:
        return (rc == X86EMUL_UNHANDLEABLE) ? -1 : 0;

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8f45cc7..04ca343 100644 (file)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3806,11 +3806,6 @@ static void emulator_set_segment_selector(u16 sel, int seg,
        kvm_set_segment(vcpu, &kvm_seg, seg);
 }
 
-static void emulator_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags)
-{
-       kvm_x86_ops->set_rflags(vcpu, rflags);
-}
-
 static struct x86_emulate_ops emulate_ops = {
        .read_std            = kvm_read_guest_virt_system,
        .write_std           = kvm_write_guest_virt_system,
@@ -3829,7 +3824,6 @@ static struct x86_emulate_ops emulate_ops = {
        .get_cr              = emulator_get_cr,
        .set_cr              = emulator_set_cr,
        .cpl                 = emulator_get_cpl,
-       .set_rflags          = emulator_set_rflags,
        .get_dr              = emulator_get_dr,
        .set_dr              = emulator_set_dr,
        .set_msr             = kvm_set_msr,
@@ -3941,6 +3935,7 @@ restart:
 
        shadow_mask = vcpu->arch.emulate_ctxt.interruptibility;
        kvm_x86_ops->set_interrupt_shadow(vcpu, shadow_mask);
+       kvm_x86_ops->set_rflags(vcpu, vcpu->arch.emulate_ctxt.eflags);
        kvm_rip_write(vcpu, vcpu->arch.emulate_ctxt.eip);
 
        if (vcpu->arch.pio.count) {