[media] media: bcm2048: fix several macros
authorNikola Jelic <nikola.jelic83@gmail.com>
Sat, 8 Apr 2017 15:44:41 +0000 (12:44 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 10 Apr 2017 17:44:08 +0000 (14:44 -0300)
Some of the macros didn't use the parenthesis around the parameters when
used in the body of the macro.

Signed-off-by: Nikola Jelic <nikola.jelic83@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/bcm2048/radio-bcm2048.c

index 375c617..38f72d0 100644 (file)
 
 #define BCM2048_FREQDEV_UNIT           10000
 #define BCM2048_FREQV4L2_MULTI         625
-#define dev_to_v4l2(f) ((f * BCM2048_FREQDEV_UNIT) / BCM2048_FREQV4L2_MULTI)
-#define v4l2_to_dev(f) ((f * BCM2048_FREQV4L2_MULTI) / BCM2048_FREQDEV_UNIT)
+#define dev_to_v4l2(f) (((f) * BCM2048_FREQDEV_UNIT) / BCM2048_FREQV4L2_MULTI)
+#define v4l2_to_dev(f) (((f) * BCM2048_FREQV4L2_MULTI) / BCM2048_FREQDEV_UNIT)
 
-#define msb(x)                  ((u8)((u16)x >> 8))
-#define lsb(x)                  ((u8)((u16)x &  0x00FF))
-#define compose_u16(msb, lsb)  (((u16)msb << 8) | lsb)
+#define msb(x)                  ((u8)((u16)(x) >> 8))
+#define lsb(x)                  ((u8)((u16)(x) &  0x00FF))
+#define compose_u16(msb, lsb)  (((u16)(msb) << 8) | (lsb))
 
 #define BCM2048_DEFAULT_POWERING_DELAY 20
 #define BCM2048_DEFAULT_REGION         0x02
@@ -2016,7 +2016,7 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,          \
        if (!bdev)                                                      \
                return -ENODEV;                                         \
                                                                        \
-       out = kzalloc(size + 1, GFP_KERNEL);                            \
+       out = kzalloc((size) + 1, GFP_KERNEL);                          \
        if (!out)                                                       \
                return -ENOMEM;                                         \
                                                                        \