Revert "ALSA: firewire-lib: fix inverted node IDs for amdtp_packet events"
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 24 Jun 2019 09:20:15 +0000 (18:20 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 24 Jun 2019 10:10:41 +0000 (12:10 +0200)
This reverts commit e703965a129cdd72ff74e248f8fbf0d617844527.

When creating this patch, I compared the value of src field to the
value of first byte of cip_header field (SID) in tracing event.
But in this test I used a device which has a quirk to transfer
isochronous packet with invalid SID. The original change is valid.

Fixes: e703965a129c ("ALSA: firewire-lib: fix inverted node IDs for amdtp_packet events")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/amdtp-stream-trace.h

index 5fe0920..ab70885 100644 (file)
@@ -35,11 +35,11 @@ TRACE_EVENT(amdtp_packet,
                __entry->cycle = cycles % CYCLES_PER_SECOND;
                __entry->channel = s->context->channel;
                if (s->direction == AMDTP_IN_STREAM) {
-                       __entry->src = fw_parent_device(s->unit)->card->node_id;
-                       __entry->dest = fw_parent_device(s->unit)->node_id;
-               } else {
                        __entry->src = fw_parent_device(s->unit)->node_id;
                        __entry->dest = fw_parent_device(s->unit)->card->node_id;
+               } else {
+                       __entry->src = fw_parent_device(s->unit)->card->node_id;
+                       __entry->dest = fw_parent_device(s->unit)->node_id;
                }
                if (cip_header) {
                        memcpy(__get_dynamic_array(cip_header), cip_header,