rtc: ds1305: put ds1305_nvmem_cfg on the stack
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 12 Feb 2018 22:47:21 +0000 (23:47 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 1 Mar 2018 09:49:16 +0000 (10:49 +0100)
This makes to code safer on system using two similar RTCs.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1305.c

index affa90d..3d2400a 100644 (file)
@@ -544,15 +544,6 @@ static int ds1305_nvram_write(void *priv, unsigned int off, void *buf,
        return spi_sync(spi, &m);
 }
 
-static struct nvmem_config ds1305_nvmem_cfg = {
-       .name = "ds1305_nvram",
-       .word_size = 1,
-       .stride = 1,
-       .size = DS1305_NVRAM_LEN,
-       .reg_read = ds1305_nvram_read,
-       .reg_write = ds1305_nvram_write,
-};
-
 /*----------------------------------------------------------------------*/
 
 /*
@@ -566,6 +557,14 @@ static int ds1305_probe(struct spi_device *spi)
        u8                              addr, value;
        struct ds1305_platform_data     *pdata = dev_get_platdata(&spi->dev);
        bool                            write_ctrl = false;
+       struct nvmem_config ds1305_nvmem_cfg = {
+               .name = "ds1305_nvram",
+               .word_size = 1,
+               .stride = 1,
+               .size = DS1305_NVRAM_LEN,
+               .reg_read = ds1305_nvram_read,
+               .reg_write = ds1305_nvram_write,
+       };
 
        /* Sanity check board setup data.  This may be hooked up
         * in 3wire mode, but we don't care.  Note that unless