// RUN: %clang_cc1 -O -fexperimental-sanitize-metadata=atomics -triple x86_64-gnu-linux -x c -S -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,ATOMICS
// RUN: %clang_cc1 -O -fexperimental-sanitize-metadata=atomics -triple aarch64-gnu-linux -x c -S -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,ATOMICS
+// CHECK: @__start_sanmd_atomics = extern_weak hidden global ptr
+// CHECK: @__stop_sanmd_atomics = extern_weak hidden global ptr
+// CHECK: @__start_sanmd_covered = extern_weak hidden global ptr
+// CHECK: @__stop_sanmd_covered = extern_weak hidden global ptr
+
int x, y;
void empty() {
// Get start/end section marker pointer.
GlobalVariable *getSectionMarker(const Twine &MarkerName, Type *Ty);
- // Create a 0-sized object in a section, so that the section is not discarded
- // if all inputs have been discarded.
- void createZeroSizedObjectInSection(Type *Ty, StringRef SectionSuffix);
-
// Returns the target-dependent section name.
StringRef getSectionName(StringRef SectionSuffix);
}
appendToGlobalCtors(Mod, Ctor, kCtorDtorPriority, CtorData);
appendToGlobalDtors(Mod, Dtor, kCtorDtorPriority, DtorData);
- createZeroSizedObjectInSection(Int8PtrTy, MI->SectionSuffix);
}
return true;
GlobalVariable *
SanitizerBinaryMetadata::getSectionMarker(const Twine &MarkerName, Type *Ty) {
+ // Use ExternalWeak so that if all sections are discarded due to section
+ // garbage collection, the linker will not report undefined symbol errors.
auto *Marker = new GlobalVariable(Mod, Ty, /*isConstant=*/false,
- GlobalVariable::ExternalLinkage,
+ GlobalVariable::ExternalWeakLinkage,
/*Initializer=*/nullptr, MarkerName);
Marker->setVisibility(GlobalValue::HiddenVisibility);
return Marker;
}
-void SanitizerBinaryMetadata::createZeroSizedObjectInSection(
- Type *Ty, StringRef SectionSuffix) {
- auto *DummyInit = ConstantAggregateZero::get(ArrayType::get(Ty, 0));
- auto *DummyEntry = new GlobalVariable(Mod, DummyInit->getType(), true,
- GlobalVariable::ExternalLinkage,
- DummyInit, "__dummy_" + SectionSuffix);
- DummyEntry->setSection(getSectionName(SectionSuffix));
- DummyEntry->setVisibility(GlobalValue::HiddenVisibility);
- if (TargetTriple.supportsCOMDAT())
- DummyEntry->setComdat(Mod.getOrInsertComdat(DummyEntry->getName()));
- // Make sure the section isn't discarded by gc-sections.
- appendToUsed(Mod, DummyEntry);
-}
-
StringRef SanitizerBinaryMetadata::getSectionName(StringRef SectionSuffix) {
// FIXME: Other TargetTriple (req. string pool)
return SectionSuffix;
; RUN: opt < %s -passes='module(sanmd-module)' -sanitizer-metadata-atomics -S | FileCheck %s
; Check that atomic memory operations receive PC sections metadata.
+
+; CHECK: @__start_sanmd_atomics = extern_weak hidden global ptr
+; CHECK: @__stop_sanmd_atomics = extern_weak hidden global ptr
+; CHECK: @__start_sanmd_covered = extern_weak hidden global ptr
+; CHECK: @__stop_sanmd_covered = extern_weak hidden global ptr
+
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
define i8 @atomic8_load_unordered(ptr %a) nounwind uwtable {