clk: imx: clk-sscg-pll: Drop unnecessary initialization
authorAnson Huang <Anson.Huang@nxp.com>
Fri, 21 Feb 2020 06:59:36 +0000 (14:59 +0800)
committerShawn Guo <shawnguo@kernel.org>
Mon, 24 Feb 2020 07:49:25 +0000 (15:49 +0800)
No need to initialize 'ret' in many functions, as it will get
the return value from function call, so remove the initializtion
of 'ret'.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
drivers/clk/imx/clk-sscg-pll.c

index acd1b90..d4a2be1 100644 (file)
@@ -195,10 +195,10 @@ static int clk_sscg_pll2_find_setup(struct clk_sscg_pll_setup *setup,
                                        uint64_t ref)
 {
 
-       int ret = -EINVAL;
+       int ret;
 
        if (ref < PLL_STAGE1_MIN_FREQ || ref > PLL_STAGE1_MAX_FREQ)
-               return ret;
+               return -EINVAL;
 
        temp_setup->vco1 = ref;
 
@@ -254,10 +254,10 @@ static int clk_sscg_pll1_find_setup(struct clk_sscg_pll_setup *setup,
                                        uint64_t ref)
 {
 
-       int ret = -EINVAL;
+       int ret;
 
        if (ref < PLL_REF_MIN_FREQ || ref > PLL_REF_MAX_FREQ)
-               return ret;
+               return -EINVAL;
 
        temp_setup->ref = ref;
 
@@ -428,7 +428,7 @@ static int __clk_sscg_pll_determine_rate(struct clk_hw *hw,
        struct clk_sscg_pll_setup *setup = &pll->setup;
        struct clk_hw *parent_hw = NULL;
        int bypass_parent_index;
-       int ret = -EINVAL;
+       int ret;
 
        req->max_rate = max;
        req->min_rate = min;
@@ -467,10 +467,10 @@ static int clk_sscg_pll_determine_rate(struct clk_hw *hw,
        uint64_t rate = req->rate;
        uint64_t min = req->min_rate;
        uint64_t max = req->max_rate;
-       int ret = -EINVAL;
+       int ret;
 
        if (rate < PLL_OUT_MIN_FREQ || rate > PLL_OUT_MAX_FREQ)
-               return ret;
+               return -EINVAL;
 
        ret = __clk_sscg_pll_determine_rate(hw, req, req->rate, req->rate,
                                                rate, PLL_BYPASS2);