Fix memory leak 47/176547/1 accepted/tizen/unified/20180423.062755 accepted/tizen/unified/20180425.062408 submit/tizen/20180420.024320 submit/tizen/20180425.024734
authorKiseok Chang <kiso.chang@samsung.com>
Fri, 20 Apr 2018 02:33:27 +0000 (11:33 +0900)
committerKiseok Chang <kiso.chang@samsung.com>
Fri, 20 Apr 2018 02:39:21 +0000 (11:39 +0900)
- free default_font_name before return

Change-Id: Idcb3076737f7e296547d51e1c0f4bc7c4079d844
Signed-off-by: Kiseok Chang <kiso.chang@samsung.com>
setting-font/src/setting-font-main.c

index 96eacb56c51cca1fc8fa680a8433d8361ffc26f7..e856367bcc7b086b3deee31ef868f74b9b5f7081 100755 (executable)
@@ -997,8 +997,12 @@ static int setting_font_main_create(void *cb)
                SETTING_TRACE_DEBUG("default_font_name:%s", default_font_name);
                Setting_GenGroupItem_Data *item_data = (Setting_GenGroupItem_Data *)
                                calloc(1, sizeof(Setting_GenGroupItem_Data));
-               setting_retvm_if(!item_data, SETTING_RETURN_SUCCESS,
-                               "calloc failed");
+               if (!item_data) {
+                       FREE(default_font_name);
+                       SETTING_TRACE_ERROR("calloc failed");
+                       return SETTING_RETURN_SUCCESS;
+               }
+
                item_data->keyStr2 = (char *)g_strdup(
                                SETTING_DEFAULT_FONT_TYPE);/*for display */
                /*for tts reading */
@@ -1041,8 +1045,12 @@ static int setting_font_main_create(void *cb)
                                        (char *)font_data);
                        Setting_GenGroupItem_Data *item_data = (Setting_GenGroupItem_Data *)calloc(
                                        1, sizeof(Setting_GenGroupItem_Data));
-                       setting_retvm_if(!item_data, SETTING_RETURN_SUCCESS,
-                                       "calloc failed");
+                       if (!item_data) {
+                               FREE(default_font_name);
+                               SETTING_TRACE_ERROR("calloc failed");
+                               return SETTING_RETURN_SUCCESS;
+                       }
+
                        /*for display */
                        item_data->keyStr2 = (char *)g_strdup(temp);
                        /*for tts reading */