qa-report: Pass the whole monitor when creating a report

So we have the proper source name already avalaible and in the future
we might need some more informations about the monitor itself.

diff --git a/validate/gst/qa/gst-qa-monitor.c b/validate/gst/qa/gst-qa-monitor.c
index 911e288..3992969 100644 (file)
--- a/validate/gst/qa/gst-qa-monitor.c
+++ b/validate/gst/qa/gst-qa-monitor.c
@@ -236,9 +236,7 @@ gst_qa_monitor_do_report_valist (GstQaMonitor * monitor,
   GstQaReport *report;
 
   message = g_strdup_vprintf (format, var_args);
-  report =
-      gst_qa_report_new (GST_OBJECT_CAST (GST_QA_MONITOR_GET_OBJECT
-          (monitor)), level, area, subarea, message);
+  report = gst_qa_report_new (monitor, level, area, subarea, message);
 
   GST_INFO_OBJECT (monitor, "Received error report %d : %d : %d : %s",
       level, area, subarea, message);

diff --git a/validate/gst/qa/gst-qa-report.c b/validate/gst/qa/gst-qa-report.c
index 657be48..998957f 100644 (file)
--- a/validate/gst/qa/gst-qa-report.c
+++ b/validate/gst/qa/gst-qa-report.c
@@ -22,6 +22,7 @@
 #include <string.h>
 
 #include "gst-qa-report.h"
+#include "gst-qa-monitor.h"
 
 static GstClockTime _gst_qa_report_start_time = 0;
 static GstQaDebugFlags _gst_qa_flags = 0;
@@ -175,7 +176,7 @@ gst_qa_report_check_abort (GstQaReport * report)
 }
 
 GstQaReport *
-gst_qa_report_new (GstObject * source, GstQaReportLevel level,
+gst_qa_report_new (GstQaMonitor * monitor, GstQaReportLevel level,
     GstQaReportArea area, gint subarea, const gchar * message)
 {
   GstQaReport *report = g_slice_new0 (GstQaReport);
@@ -183,11 +184,7 @@ gst_qa_report_new (GstObject * source, GstQaReportLevel level,
   report->level = level;
   report->area = area;
   report->subarea = subarea;
-  if (GST_IS_PAD (source))
-    report->source_name =
-        g_strdup_printf ("%s:%s", GST_DEBUG_PAD_NAME (source));
-  else
-    report->source_name = g_strdup (GST_OBJECT_NAME (source));
+  report->source_name = g_strdup (monitor->target_name);
   report->message = g_strdup (message);
   report->timestamp = gst_util_get_timestamp () - _gst_qa_report_start_time;
 

diff --git a/validate/gst/qa/gst-qa-report.h b/validate/gst/qa/gst-qa-report.h
index e2b2084..14689b4 100644 (file)
--- a/validate/gst/qa/gst-qa-report.h
+++ b/validate/gst/qa/gst-qa-report.h
@@ -27,6 +27,9 @@
 
 G_BEGIN_DECLS
 
+/* forward declaration */
+typedef struct _GstQaMonitor GstQaMonitor;
+
 GType           gst_qa_report_get_type (void);
 #define GST_TYPE_QA_REPORT (gst_qa_report_get_type ())
 
@@ -103,7 +106,8 @@ typedef struct {
                                     r->message
 
 void               gst_qa_report_init (void);
-GstQaReport *      gst_qa_report_new (GstObject * source, GstQaReportLevel level, GstQaReportArea area,
+GstQaReport *      gst_qa_report_new (GstQaMonitor * monitor, GstQaReportLevel level,
+                                      GstQaReportArea area,
                                       gint subarea, const gchar * message);
 void               gst_qa_report_unref (GstQaReport * report);
 GstQaReport *      gst_qa_report_ref   (GstQaReport * report);