policychecker: removed at_console from checking duplicates 47/186947/2 accepted/tizen/5.0/unified/20181102.021905 accepted/tizen/5.0/unified/20181113.090038 accepted/tizen/unified/20180821.091103 submit/tizen/20180820.105030 submit/tizen_5.0/20181101.000004 submit/tizen_5.0/20181112.020142
authorAdrian Szyndela <adrian.s@samsung.com>
Thu, 16 Aug 2018 12:40:21 +0000 (14:40 +0200)
committerAdrian Szyndela <adrian.s@samsung.com>
Mon, 20 Aug 2018 09:41:51 +0000 (11:41 +0200)
At_console has its own "deprecated" checking rule, so we assume that
at_console rules are those to be removed. Thus, there is no point
in showing "duplicate" warning for duplicate rules in other contexts.

Change-Id: Ifdf7e3745d7ece49772ba3a3aad01a213b657d0c

policychecker/same.xsl

index c90a4d973808e4d5e0b6ac11816755c08932d9e7..c7a3f2c54f7151fcf7c552fef4060467b98dc791 100644 (file)
 </xsl:if>
        </xsl:template>
 
-       <!-- user vs context, at_console -->
+       <!-- user vs context -->
        <xsl:template match="//policy[@user]/*">
                <!-- we cannot compare with group policies as we don't know which group rules will be applied to the current user (TODO? supply a user->groups mapping )-->
                <xsl:call-template name="find-duplicates">
                        <xsl:with-param name="curr_rule" select="."/>
                        <xsl:with-param name="other_rules" select="//policy[@context]/*"/>
                </xsl:call-template>
-               <xsl:call-template name="find-duplicates">
-                       <xsl:with-param name="curr_rule" select="."/>
-                       <xsl:with-param name="other_rules" select="//policy[@at_console]/*"/>
-               </xsl:call-template>
        </xsl:template>
 
-       <!-- group vs context, at_console -->
+       <!-- group vs context -->
        <xsl:template match="//policy[@group]/*">
                <xsl:call-template name="find-duplicates">
                        <xsl:with-param name="curr_rule" select="."/>
                        <xsl:with-param name="other_rules" select="//policy[@context]/*"/>
                </xsl:call-template>
-               <xsl:call-template name="find-duplicates">
-                       <xsl:with-param name="curr_rule" select="."/>
-                       <xsl:with-param name="other_rules" select="//policy[@at_console]/*"/>
-               </xsl:call-template>
-       </xsl:template>
-
-       <!-- at_console='true' vs context, at_console='false' -->
-       <xsl:template match="//policy[@at_console='true']/*">
-               <xsl:call-template name="find-duplicates">
-                       <xsl:with-param name="curr_rule" select="."/>
-                       <xsl:with-param name="other_rules" select="//policy[@context]/*"/>
-               </xsl:call-template>
-               <xsl:call-template name="find-duplicates">
-                       <xsl:with-param name="curr_rule" select="."/>
-                       <xsl:with-param name="other_rules" select="//policy[@at_console='false']/*"/>
-               </xsl:call-template>
        </xsl:template>
 
        <!-- context='default' vs context='mandatory' -->