Send to helix only when previous steps succeeded (dotnet/corefx#37332)

Commit migrated from https://github.com/dotnet/corefx/commit/5ed8c52f6a6d78267fe5857f7a67780ea02cc7a8

diff --git a/eng/pipelines/libraries/corefx-base.yml b/eng/pipelines/libraries/corefx-base.yml
index 3989322..4db5f43 100644 (file)
--- a/eng/pipelines/libraries/corefx-base.yml
+++ b/eng/pipelines/libraries/corefx-base.yml
@@ -190,7 +190,7 @@ jobs:
             - template: /eng/pipelines/helix.yml
               parameters:
                 # send tests to helix only on public builds, official scheduled builds or manual official builds.
-                condition: ${{ or(eq(parameters.isOfficialBuild, 'false'), notIn(variables['Build.Reason'], 'BatchedCI', 'IndividualCI')) }}
+                condition: or(eq(${{ parameters.isOfficialBuild }}, 'false'), notIn(variables['Build.Reason'], 'BatchedCI', 'IndividualCI'))
                 targetOS: ${{ parameters.targetOS }}
                 archGroup: $(_architecture)
                 configuration: $(_BuildConfig)

diff --git a/eng/pipelines/libraries/helix.yml b/eng/pipelines/libraries/helix.yml
index a1f478c..cf1bf9d 100644 (file)
--- a/eng/pipelines/libraries/helix.yml
+++ b/eng/pipelines/libraries/helix.yml
@@ -33,6 +33,6 @@ steps:
             /p:EnableAzurePipelinesReporter=${{ parameters.enableAzurePipelinesReporter }}
             /bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog
     displayName: Send to Helix
-    condition: ${{ parameters.condition }}
+    condition: and(succeeded(), ${{ parameters.condition }})
     env:
       SYSTEM_ACCESSTOKEN: $(System.AccessToken) # We need to set this env var to publish helix results to Azure Dev Ops