erofs: fold in used-once helper erofs_workgroup_unfreeze_final()
authorGao Xiang <hsiangkao@redhat.com>
Wed, 29 Jul 2020 18:02:35 +0000 (02:02 +0800)
committerGao Xiang <hsiangkao@redhat.com>
Mon, 3 Aug 2020 13:04:46 +0000 (21:04 +0800)
It's expected that erofs_workgroup_unfreeze_final() won't
be used in other places. Let's fold it to simplify the code.

Link: https://lore.kernel.org/r/20200729180235.25443-1-hsiangkao@redhat.com
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
fs/erofs/utils.c

index ecb85b3..de9986d 100644 (file)
@@ -127,12 +127,6 @@ int erofs_workgroup_put(struct erofs_workgroup *grp)
        return count;
 }
 
-static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
-{
-       erofs_workgroup_unfreeze(grp, 0);
-       __erofs_workgroup_free(grp);
-}
-
 static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
                                           struct erofs_workgroup *grp)
 {
@@ -162,11 +156,9 @@ static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
         */
        DBG_BUGON(xa_erase(&sbi->managed_pslots, grp->index) != grp);
 
-       /*
-        * If managed cache is on, last refcount should indicate
-        * the related workstation.
-        */
-       erofs_workgroup_unfreeze_final(grp);
+       /* last refcount should be connected with its managed pslot.  */
+       erofs_workgroup_unfreeze(grp, 0);
+       __erofs_workgroup_free(grp);
        return true;
 }