media: atomisp_gmin_platform: Do not turn ELDO2 off from axp_v1p8_on()
authorHans de Goede <hdegoede@redhat.com>
Sun, 16 Jan 2022 21:52:02 +0000 (22:52 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 8 Feb 2022 05:28:38 +0000 (06:28 +0100)
Fix axp_v1p8_on() turning ELDO2 off at the end again by removing the bogus
code which turns it off again after just having turned it on.

Link: https://lore.kernel.org/linux-media/20220116215204.307649-8-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

index 1c3fd72..84a4531 100644 (file)
@@ -769,11 +769,6 @@ static int axp_v1p8_on(struct device *dev, struct gmin_subdev *gs)
 
        ret = axp_regulator_set(dev, gs, gs->eldo1_sel_reg, gs->eldo1_1p6v,
                                ELDO_CTRL_REG, gs->eldo1_ctrl_shift, true);
-       if (ret)
-               return ret;
-
-       ret = axp_regulator_set(dev, gs, gs->eldo2_sel_reg, gs->eldo2_1p8v,
-                               ELDO_CTRL_REG, gs->eldo2_ctrl_shift, false);
        return ret;
 }