converted DBG to WARN in case of errors

diff --git a/src/daemon/gumd-daemon-user.c b/src/daemon/gumd-daemon-user.c
index 6483dae..a3213c7 100644 (file)
--- a/src/daemon/gumd-daemon-user.c
+++ b/src/daemon/gumd-daemon-user.c
@@ -1096,8 +1096,6 @@ _set_group (
             "grouptype", grp_type, NULL);
     if (!(added = gumd_daemon_group_add (group, (gid_t)self->priv->pw->pw_uid,
             &gid, error))) {
-        GUM_SET_ERROR (GUM_ERROR_USER_GROUP_ADD_FAILURE,
-                        "Group add failure", error, added, FALSE);
         goto _finished;
     }
     _set_gid_property (self, gid);

diff --git a/src/lib/gum-group.c b/src/lib/gum-group.c
index a29678a..67f1fb1 100644 (file)
--- a/src/lib/gum-group.c
+++ b/src/lib/gum-group.c
@@ -422,7 +422,7 @@ _sync_properties (
             &error);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         return FALSE;
@@ -692,7 +692,7 @@ gum_group_create_sync ()
     g_free (object_path);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         g_object_unref (group);
@@ -758,7 +758,7 @@ gum_group_get_sync (
     g_free (object_path);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         g_object_unref (group);
@@ -832,7 +832,7 @@ gum_group_get_by_name_sync (
     g_free (object_path);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         g_object_unref (group);
@@ -865,7 +865,7 @@ gum_group_add (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -895,14 +895,14 @@ gum_group_add_sync (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_group_call_add_group_sync (self->priv->dbus_group,
             GUM_GROUP_INVALID_GID, &gid, self->priv->cancellable, &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }
@@ -936,7 +936,7 @@ gum_group_delete (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -964,14 +964,14 @@ gum_group_delete_sync (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_group_call_delete_group_sync (self->priv->dbus_group,
             self->priv->cancellable, &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }
@@ -1006,7 +1006,7 @@ gum_group_update (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -1035,14 +1035,14 @@ gum_group_update_sync (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_group_call_update_group_sync (self->priv->dbus_group,
             self->priv->cancellable, &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }
@@ -1081,7 +1081,7 @@ gum_group_add_member (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -1115,14 +1115,14 @@ gum_group_add_member_sync (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_group_call_add_member_sync (self->priv->dbus_group, uid,
             add_as_admin, self->priv->cancellable, &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }
@@ -1158,7 +1158,7 @@ gum_group_delete_member (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -1188,14 +1188,14 @@ gum_group_delete_member_sync (
     g_return_val_if_fail (GUM_IS_GROUP (self), FALSE);
 
     if (!self->priv->dbus_group) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_group_call_delete_member_sync (self->priv->dbus_group, uid,
             self->priv->cancellable, &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }

diff --git a/src/lib/gum-user.c b/src/lib/gum-user.c
index 271a73c..e08a733 100644 (file)
--- a/src/lib/gum-user.c
+++ b/src/lib/gum-user.c
@@ -548,7 +548,7 @@ _sync_properties (
             &error);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         return FALSE;
@@ -774,7 +774,7 @@ gum_user_create_sync ()
     g_free (object_path);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         g_object_unref (user);
@@ -838,7 +838,7 @@ gum_user_get_sync (
     g_free (object_path);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         g_object_unref (user);
@@ -911,7 +911,7 @@ gum_user_get_by_name_sync (
     g_free (object_path);
 
     if (error) {
-        DBG ("Failed with error %d:%s", error->code, error->message);
+        WARN ("Failed with error %d:%s", error->code, error->message);
         g_error_free (error);
         error = NULL;
         g_object_unref (user);
@@ -946,7 +946,7 @@ gum_user_add (
     g_return_val_if_fail (GUM_IS_USER (self), FALSE);
 
     if (!self->priv->dbus_user) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -976,20 +976,19 @@ gum_user_add_sync (
     uid_t uid = GUM_USER_INVALID_UID;
 
     if (!self->priv->dbus_user) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_user_call_add_user_sync (
             self->priv->dbus_user, &uid, self->priv->cancellable,  &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }
         return FALSE;
     }
-
     return _sync_properties (self);
 }
 
@@ -1019,7 +1018,7 @@ gum_user_delete (
     g_return_val_if_fail (GUM_IS_USER (self), FALSE);
 
     if (!self->priv->dbus_user) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -1049,7 +1048,7 @@ gum_user_delete_sync (
     g_return_val_if_fail (GUM_IS_USER (self), FALSE);
 
     if (!self->priv->dbus_user) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
@@ -1057,7 +1056,7 @@ gum_user_delete_sync (
             self->priv->dbus_user, rem_home_dir, self->priv->cancellable,
             &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }
@@ -1092,7 +1091,7 @@ gum_user_update (
     g_return_val_if_fail (GUM_IS_USER (self), FALSE);
 
     if (!self->priv->dbus_user) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
     _create_op (self, callback, user_data);
@@ -1122,14 +1121,14 @@ gum_user_update_sync (
     g_return_val_if_fail (GUM_IS_USER (self), FALSE);
 
     if (!self->priv->dbus_user) {
-        DBG ("Remote dbus object not valid");
+        WARN ("Remote dbus object not valid");
         return FALSE;
     }
 
     if (!gum_dbus_user_call_update_user_sync (
             self->priv->dbus_user, self->priv->cancellable, &error)) {
         if (error) {
-            DBG ("Failed with error %d:%s", error->code, error->message);
+            WARN ("Failed with error %d:%s", error->code, error->message);
             g_error_free (error);
             error = NULL;
         }