drm/vmwgfx: Replace one-element array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 3 Feb 2023 01:27:10 +0000 (19:27 -0600)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 6 Mar 2023 20:17:45 +0000 (14:17 -0600)
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct vmw_view.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

This results in no differences in binary output.

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/254
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
drivers/gpu/drm/vmwgfx/vmwgfx_so.c

index 4ea32b0..0f696cc 100644 (file)
@@ -70,7 +70,7 @@ struct vmw_view {
        unsigned view_id;              /* Immutable */
        u32 cmd_size;                  /* Immutable */
        bool committed;                /* Protected by binding_mutex */
-       u32 cmd[1];                    /* Immutable */
+       u32 cmd[];                     /* Immutable */
 };
 
 static int vmw_view_create(struct vmw_resource *res);