drm/amdgpu: add fw release for sdma v5_0
authorWenhui Sheng <Wenhui.Sheng@amd.com>
Thu, 18 Jun 2020 07:37:04 +0000 (15:37 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 24 Jun 2020 22:02:39 +0000 (18:02 -0400)
sdma fw isn't released when module exit

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Wenhui Sheng <Wenhui.Sheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c

index b544baf..5d71c23 100644 (file)
@@ -1298,8 +1298,12 @@ static int sdma_v5_0_sw_fini(void *handle)
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
        int i;
 
-       for (i = 0; i < adev->sdma.num_instances; i++)
+       for (i = 0; i < adev->sdma.num_instances; i++) {
+               if (adev->sdma.instance[i].fw != NULL)
+                       release_firmware(adev->sdma.instance[i].fw);
+
                amdgpu_ring_fini(&adev->sdma.instance[i].ring);
+       }
 
        return 0;
 }