Silence zip command output 25/206325/1
authorKarol Lewandowski <k.lewandowsk@samsung.com>
Wed, 15 May 2019 12:01:44 +0000 (14:01 +0200)
committerKarol Lewandowski <k.lewandowsk@samsung.com>
Thu, 16 May 2019 09:25:20 +0000 (11:25 +0200)
zip, as any other process, should not pollute our standard output
unless explicitly asked to do so.

Change-Id: Ied5d31e453c528fffd9662aa5b324e0b7a743dbc

src/crash-manager/crash-manager.c
src/log_dump/log_dump.c

index ea5b10a..9e7bd49 100644 (file)
@@ -912,14 +912,7 @@ static void compress(struct crash_info *cinfo)
                return;
        }
 
-       char *args[] = {
-               "/bin/zip",
-               "-y",
-               "-r",
-               zip_path,
-               cinfo->name,
-               NULL
-       };
+       char *args[] = {"/bin/zip", "-qyr", zip_path, cinfo->name, NULL};
 
        spawn_param_u param = { .char_ptr = cinfo->temp_dir };
        (void)spawn_wait(args, NULL, spawn_chdir, &param, ZIP_TIMEOUT_MS, NULL);
index c20149f..aa63f2b 100644 (file)
@@ -222,7 +222,7 @@ static bool compress(char *const destdir, char *const tempdir, char *const versi
        }
 
        _D("compress tempdir is %s", tempdir);
-       char *av[] = {"/bin/zip", "-yr", archive_path, ".", NULL};
+       char *av[] = {"/bin/zip", "-qyr", archive_path, ".", NULL};
        spawn_param_u param = { .char_ptr = tempdir };
        bool is_ok = spawn_wait(av, NULL, spawn_chdir, &param, 0, exit_code);