net/ipv6: fix bool/int mismatch for skip_notify_on_dev_down
authorEric Dumazet <edumazet@google.com>
Thu, 1 Jun 2023 16:04:44 +0000 (16:04 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 3 Jun 2023 05:55:43 +0000 (22:55 -0700)
skip_notify_on_dev_down ctl table expects this field
to be an int (4 bytes), not a bool (1 byte).

Because proc_dou8vec_minmax() was added in 5.13,
this patch converts skip_notify_on_dev_down to an int.

Following patch then converts the field to u8 and use proc_dou8vec_minmax().

Fixes: 7c6bb7d2faaf ("net/ipv6: Add knob to skip DELROUTE message on device down")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/netns/ipv6.h

index 3cceb3e9320b9c614026846a451676edf766e4d3..d44b2ee49698fa17bef0c54df8c960ec5addcbd0 100644 (file)
@@ -53,7 +53,7 @@ struct netns_sysctl_ipv6 {
        int seg6_flowlabel;
        u32 ioam6_id;
        u64 ioam6_id_wide;
-       bool skip_notify_on_dev_down;
+       int skip_notify_on_dev_down;
        u8 fib_notify_on_flag_change;
        u8 icmpv6_error_anycast_as_unicast;
 };