Staging: kpc2000: kpc_dma: Use kcalloc over kzalloc.
authorSam Muhammed <jane.pnx9@gmail.com>
Wed, 25 Mar 2020 14:26:41 +0000 (10:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Mar 2020 18:38:40 +0000 (19:38 +0100)
Replace kzalloc(sizeof(...) * n, ...) with
kcalloc(n, sizeof(...), ...) since kcalloc is the
preferred API in case of allocating with multiply.

Checkpatch.pl: WARNING:
Prefer kcalloc over kzalloc with multiply.

Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/4b8339d1e81e497c3c2f0dad57a9587338ec82b1.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc_dma/fileops.c

index d80d894..8c7859e 100644 (file)
@@ -66,7 +66,8 @@ static int kpc_dma_transfer(struct dev_private_data *priv,
        acd->page_count = count_pages(iov_base, iov_len);
 
        // Allocate an array of page pointers
-       acd->user_pages = kzalloc(sizeof(struct page *) * acd->page_count, GFP_KERNEL);
+       acd->user_pages = kcalloc(acd->page_count, sizeof(struct page *),
+                                 GFP_KERNEL);
        if (!acd->user_pages) {
                dev_err(&priv->ldev->pldev->dev, "Couldn't kmalloc space for for the page pointers\n");
                rv = -ENOMEM;