GDBusMethodInvocation: add missing 'goto out'
authorRyan Lortie <desrt@desrt.ca>
Sat, 22 Jun 2013 17:41:12 +0000 (13:41 -0400)
committerRyan Lortie <desrt@desrt.ca>
Sat, 22 Jun 2013 17:41:12 +0000 (13:41 -0400)
We do a bunch of new validity checks for return values in response to
calls on the D-Bus property API but we miss the 'goto out' in one case.
Add it.

https://bugzilla.gnome.org/show_bug.cgi?id=698375

gio/gdbusmethodinvocation.c

index bd40aaf..c6cab91 100644 (file)
@@ -444,6 +444,8 @@ g_dbus_method_invocation_return_value_internal (GDBusMethodInvocation *invocatio
               g_warning ("Value returned from property 'Get' call for '%s' should be '%s' but is '%s'",
                          invocation->property_info->name, invocation->property_info->signature,
                          g_variant_get_type_string (nested));
+              g_variant_unref (nested);
+              goto out;
             }
           g_variant_unref (nested);
         }