IPoIB/cm: Clean up initialization of QP attr in ipoib_cm_create_tx_qp()
authorDotan Barak <dotanb@dev.mellanox.co.il>
Sun, 7 Oct 2007 07:30:48 +0000 (09:30 +0200)
committerRoland Dreier <rolandd@cisco.com>
Wed, 10 Oct 2007 02:59:18 +0000 (19:59 -0700)
Make the way QP is being created in ipoib_cm_create_tx_qp()
consistent with ipoib_cm_create_rx_qp().

Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/ulp/ipoib/ipoib_cm.c

index 08b4676..23addb3 100644 (file)
@@ -810,14 +810,16 @@ static int ipoib_cm_rep_handler(struct ib_cm_id *cm_id, struct ib_cm_event *even
 static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ib_cq *cq)
 {
        struct ipoib_dev_priv *priv = netdev_priv(dev);
-       struct ib_qp_init_attr attr = {};
-       attr.recv_cq = priv->cq;
-       attr.srq = priv->cm.srq;
-       attr.cap.max_send_wr = ipoib_sendq_size;
-       attr.cap.max_send_sge = 1;
-       attr.sq_sig_type = IB_SIGNAL_ALL_WR;
-       attr.qp_type = IB_QPT_RC;
-       attr.send_cq = cq;
+       struct ib_qp_init_attr attr = {
+               .send_cq                = cq,
+               .recv_cq                = priv->cq,
+               .srq                    = priv->cm.srq,
+               .cap.max_send_wr        = ipoib_sendq_size,
+               .cap.max_send_sge       = 1,
+               .sq_sig_type            = IB_SIGNAL_ALL_WR,
+               .qp_type                = IB_QPT_RC,
+        };
+
        return ib_create_qp(priv->pd, &attr);
 }