NFC: nxp-nci: Don't issue a zero length i2c_master_read()
authorMichael Walle <michael@walle.cc>
Mon, 27 Jun 2022 17:06:42 +0000 (19:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Jun 2022 13:05:00 +0000 (14:05 +0100)
There are packets which doesn't have a payload. In that case, the second
i2c_master_read() will have a zero length. But because the NFC
controller doesn't have any data left, it will NACK the I2C read and
-ENXIO will be returned. In case there is no payload, just skip the
second i2c master read.

Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/nfc/nxp-nci/i2c.c

index 7e451c1..e8f3b35 100644 (file)
@@ -162,6 +162,9 @@ static int nxp_nci_i2c_nci_read(struct nxp_nci_i2c_phy *phy,
 
        skb_put_data(*skb, (void *)&header, NCI_CTRL_HDR_SIZE);
 
+       if (!header.plen)
+               return 0;
+
        r = i2c_master_recv(client, skb_put(*skb, header.plen), header.plen);
        if (r != header.plen) {
                nfc_err(&client->dev,