[0.6.131] add comments 63/189363/1
authorEunhae Choi <eunhae1.choi@samsung.com>
Mon, 17 Sep 2018 08:09:53 +0000 (17:09 +0900)
committerEunhae Choi <eunhae1.choi@samsung.com>
Mon, 17 Sep 2018 08:09:53 +0000 (17:09 +0900)
Change-Id: I5cb1b1378dd10ddbc8c294f535b7eafd9028b230

src/mm_player_gst.c
src/mm_player_priv.c
src/mm_player_streaming.c

index fb8bc109f707e715fcfe69269c4916e9622ae8c9..1c9ab1981a0e804432947cac081516220f656f8f 100644 (file)
@@ -1036,8 +1036,9 @@ __mmplayer_update_buffer_setting(mm_player_t *player, GstMessage *buffering_msg)
 
                if (stat(path, &sb) == 0)
                        data_size = (guint64)sb.st_size;
-       } else if (MMPLAYER_IS_HTTP_STREAMING(player))
+       } else if (MMPLAYER_IS_HTTP_STREAMING(player)) {
                data_size = player->http_content_size;
+       }
 
        __mm_player_streaming_buffering(player->streamer, buffering_msg, data_size, player->last_position, player->duration);
        __mm_player_streaming_sync_property(player->streamer, player->pipeline->mainbin[MMPLAYER_M_AUTOPLUG].gst);
index 0a8b178f3465e114f3476bab056faef21a4f1d36..1464b824873661a383d756d14ef54ea4e60eab29 100644 (file)
@@ -9946,23 +9946,28 @@ int _mmplayer_set_codec_type(MMHandleType hplayer, MMPlayerStreamType stream_typ
 
        switch (stream_type) {
        case MM_PLAYER_STREAM_TYPE_AUDIO:
+       /* to support audio codec selection, codec info have to be added in ini file as below.
+          audio codec element hw = xxxx
+          audio codec element sw = avdec */
                if (((codec_type == MM_PLAYER_CODEC_TYPE_HW) &&
                         (!strcmp(player->ini.audiocodec_element_hw, ""))) ||
                        ((codec_type == MM_PLAYER_CODEC_TYPE_SW) &&
                         (!strcmp(player->ini.audiocodec_element_sw[IDX_FIRST_SW_CODEC], "")))) {
-                       LOGE("There is no a codec for codec_type %d", codec_type);
+                       LOGE("There is no audio codec info for codec_type %d", codec_type);
                        return MM_ERROR_PLAYER_NO_OP;
                }
        break;
        case MM_PLAYER_STREAM_TYPE_VIDEO:
+       /* to support video codec selection, codec info have to be added in ini file as below.
+          video codec element hw = omx
+          video codec element sw = avdec */
                if (((codec_type == MM_PLAYER_CODEC_TYPE_HW) &&
                         (!strcmp(player->ini.videocodec_element_hw, ""))) ||
                        ((codec_type == MM_PLAYER_CODEC_TYPE_SW) &&
                         (!strcmp(player->ini.videocodec_element_sw[IDX_FIRST_SW_CODEC], "")))) {
-                       LOGE("There is no v codec for codec_type %d", codec_type);
+                       LOGE("There is no video codec info for codec_type %d", codec_type);
                        return MM_ERROR_PLAYER_NO_OP;
                }
-
        break;
        default:
                LOGE("Invalid stream type %s", MMPLAYER_STREAM_TYPE_GET_NAME(stream_type));
index d7b8fe00b6f7ce54b6d8179ec1ed73012dc9a3b0..52ca01e3df4374694934227d669c70b83439a683 100644 (file)
@@ -928,7 +928,7 @@ streaming_update_buffering_status(mm_player_streaming_t* streamer, GstMessage *b
        /* update buffer percent */
        gst_message_parse_buffering(buffering_msg, &buffer_percent);
 
-       /* LOGD("buffering per %d%% -> %d%%, state 0x%X", streamer->buffering_percent, buffer_percent, streamer->buffering_state); */
+       /* LOGD("[%s] buffering per %d%% -> %d%%, state 0x%X", streamer->buffering_percent, buffer_percent, streamer->buffering_state); */
 
        if (streamer->buffering_percent < buffer_percent) {
                LOGD("[%s] buffering %d%%....",