tee: optee: fix uuid comparisons on service discovery
authorIlias Apalodimas <ilias.apalodimas@linaro.org>
Thu, 19 Jan 2023 09:21:37 +0000 (11:21 +0200)
committerIlias Apalodimas <ilias.apalodimas@linaro.org>
Fri, 20 Jan 2023 08:04:56 +0000 (10:04 +0200)
When comparing UUIDs for discovered services we only compare up to the
ptr size instead of the entire UUID

Fixes: 94ccfb78a4d61 ("drivers: tee: optee: discover OP-TEE services")
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/optee/core.c

index 88e23d2..9a9b697 100644 (file)
@@ -73,7 +73,7 @@ static struct optee_service *find_service_driver(const struct tee_optee_ta_uuid
 
        for (idx = 0; idx < service_cnt; idx++, service++) {
                tee_optee_ta_uuid_to_octets(loc_uuid, &service->uuid);
-               if (!memcmp(uuid, loc_uuid, sizeof(uuid)))
+               if (!memcmp(uuid, loc_uuid, sizeof(*uuid)))
                        return service;
        }