Remove unnecessary explicit unlock

Encapsulated mutex protection within a scoped block to ensure proper unlocking

Change-Id: I49fa28359469ee8a2042666a3f506fe80a39dc9d

diff --git a/server/ttsd_data.cpp b/server/ttsd_data.cpp
index 1d255ae1ea6f23549e884475561112b06eeb1f81..492aa8134c0298d3dfb4ccc9f930f76862f4582b 100644 (file)
--- a/server/ttsd_data.cpp
+++ b/server/ttsd_data.cpp
@@ -921,18 +921,19 @@ int ttsd_data_foreach_clients(ttsd_data_get_client_cb callback, void* user_data)
        /* Copy app info */
        vector<app_data_s> temp_app_list;
 
-       unique_lock<mutex> lock(g_app_data_mutex);
-       int vsize = g_app_list.size();
-       for (int i = 0; i < vsize; i++) {
-               app_data_s app = {0, };
-               app.pid = g_app_list[i].pid;
-               app.uid = g_app_list[i].uid;
-               app.utt_id_stopped = 0;
-               app.state = g_app_list[i].state;
-
-               temp_app_list.push_back(std::move(app));
+       {
+               unique_lock<mutex> lock(g_app_data_mutex);
+               int vsize = g_app_list.size();
+               for (int i = 0; i < vsize; i++) {
+                       app_data_s app = {0, };
+                       app.pid = g_app_list[i].pid;
+                       app.uid = g_app_list[i].uid;
+                       app.utt_id_stopped = 0;
+                       app.state = g_app_list[i].state;
+
+                       temp_app_list.push_back(std::move(app));
+               }
        }
-       lock.unlock();
 
        for (int i = 0; i < vsize; i++) {
                SECURE_SLOG(LOG_DEBUG, tts_tag(), "[%dth] pid(%d), uid(%u), state(%d)", i, temp_app_list[i].pid, temp_app_list[i].uid, temp_app_list[i].state);