RDMA/hfi: Decrease PCI device reference count in error path
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Thu, 17 Nov 2022 13:15:46 +0000 (21:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:33 +0000 (13:32 +0100)
[ Upstream commit 9b51d072da1d27e1193e84708201c48e385ad912 ]

pci_get_device() will increase the reference count for the returned
pci_dev, and also decrease the reference count for the input parameter
*from* if it is not NULL.

If we break out the loop in node_affinity_init() with 'dev' not NULL, we
need to call pci_dev_put() to decrease the reference count. Add missing
pci_dev_put() in error path.

Fixes: c513de490f80 ("IB/hfi1: Invalid NUMA node information can cause a divide by zero")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221117131546.113280-1-wangxiongfeng2@huawei.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/hfi1/affinity.c

index 877f8e8..77ee77d 100644 (file)
@@ -177,6 +177,8 @@ out:
        for (node = 0; node < node_affinity.num_possible_nodes; node++)
                hfi1_per_node_cntr[node] = 1;
 
+       pci_dev_put(dev);
+
        return 0;
 }