[SVACE] fix CID 1030252, CID 1030251 issues
authorjinhyuck-park <jinhyuck83.park@samsung.com>
Tue, 2 Oct 2018 04:49:49 +0000 (13:49 +0900)
committerMyungJoo Ham <myungjoo.ham@gmail.com>
Tue, 2 Oct 2018 08:38:18 +0000 (17:38 +0900)
SVACE issues fix for tensor decoder

Signed-off-by: jinhyuck-park <jinhyuck83.park@samsung.com>
gst/tensor_decoder/tensordec.c

index 20b9948..9dffee1 100644 (file)
@@ -683,15 +683,11 @@ gst_tensordec_update_top_label_index (GstTensorDec * self,
     guint8 * scores, guint len)
 {
   gint i;
-  gint ret;
   gint index = -1;
   guint8 max_score = 0;
 
-  /** -1 if failed to get max score index */
-  ret = -1;
-
   g_return_if_fail (scores != NULL);
-  g_return_if_fail (len == self->tensordec_image_label.total_labels);
+  g_return_val_if_fail (len == self->tensordec_image_label.total_labels, -1);
 
   for (i = 0; i < len; i++) {
     if (scores[i] > 0 && scores[i] > max_score) {
@@ -700,8 +696,7 @@ gst_tensordec_update_top_label_index (GstTensorDec * self,
     }
   }
 
-  ret = index;
-  return ret;
+  return index;
 }
 
 /**
@@ -712,7 +707,7 @@ static gchar *
 gst_get_image_label (GstTensorDec * self, gint label)
 {
   guint length;
-  guint check_label = label;
+  gint check_label = label;
   g_return_val_if_fail (self != NULL, NULL);
   g_return_val_if_fail (self->tensordec_image_label.labels != NULL, NULL);