projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f948202
)
ASoC: ti: davinci-i2s: Add check for clk_enable()
author
Jiasheng Jiang
<jiasheng@iscas.ac.cn>
Mon, 28 Feb 2022 03:15:40 +0000
(11:15 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 28 Feb 2022 13:33:54 +0000
(13:33 +0000)
As the potential failure of the clk_enable(),
it should be better to check it and return error
if fails.
Fixes:
5f9a50c3e55e
("ASoC: Davinci: McBSP: add device tree support for McBSP")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link:
https://lore.kernel.org/r/20220228031540.3571959-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/ti/davinci-i2s.c
patch
|
blob
|
history
diff --git
a/sound/soc/ti/davinci-i2s.c
b/sound/soc/ti/davinci-i2s.c
index
6dca518
..
0363a08
100644
(file)
--- a/
sound/soc/ti/davinci-i2s.c
+++ b/
sound/soc/ti/davinci-i2s.c
@@
-708,7
+708,9
@@
static int davinci_i2s_probe(struct platform_device *pdev)
dev->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(dev->clk))
return -ENODEV;
- clk_enable(dev->clk);
+ ret = clk_enable(dev->clk);
+ if (ret)
+ goto err_put_clk;
dev->dev = &pdev->dev;
dev_set_drvdata(&pdev->dev, dev);
@@
-730,6
+732,7
@@
err_unregister_component:
snd_soc_unregister_component(&pdev->dev);
err_release_clk:
clk_disable(dev->clk);
+err_put_clk:
clk_put(dev->clk);
return ret;
}