#include "lib/psm.h"
#include "lib/rpmfi_internal.h" /* XXX replaced/states, fi->hge, fi->te... */
#include "lib/rpmte_internal.h" /* XXX te->fd */
-#include "lib/rpmtsscore.h"
#include "lib/rpmlead.h" /* writeLead proto */
#include "lib/signature.h" /* signature constants */
#include "lib/misc.h" /* XXX rpmMkdirPath, doputenv */
int _psm_debug = _PSM_DEBUG;
int _psm_threads = 0;
-/* Give access to the rpmte global tracking the last instance added
- * to the database.
- */
-extern unsigned int myinstall_instance;
-
/**
*/
struct rpmpsm_s {
if (psm->te) /* XXX can't happen */
N = rpmteN(psm->te);
-/* XXX: Might need to adjust instance counts four autorollback. */
if (N) /* XXX can't happen */
numPackage = rpmdbCountPackages(rpmtsGetRdb(ts), N)
+ psm->countCorrection;
break;
}
- /* If we have a score then autorollback is enabled. If autorollback is
- * enabled, and this is an autorollback transaction, then we may need to
- * adjust the pkgs installed count.
- *
- * If all this is true, this adjustment should only be made if the PSM goal
- * is an install. No need to make this adjustment on the erase
- * component of the upgrade, or even more absurd to do this when doing a
- * PKGSAVE.
- */
- if (rpmtsGetScore(ts) != NULL &&
- rpmtsGetType(ts) == RPMTRANS_TYPE_AUTOROLLBACK &&
- (psm->goal & ~(PSM_PKGSAVE|PSM_PKGERASE))) {
- /* Get the score, if its not NULL, get the appropriate
- * score entry.
- */
- rpmtsScore score = rpmtsGetScore(ts);
- if (score != NULL) {
- /* OK, we got a real score so lets get the appropriate
- * score entry.
- */
- rpmtsScoreEntry se;
- se = rpmtsScoreGetEntry(score, rpmteN(psm->te));
-
- /* IF the header for the install element has been installed,
- * but the header for the erase element has not been erased,
- * then decrement the instance count. This is because in an
- * autorollback, if the header was added in the initial transaction
- * then in the case of an upgrade the instance count will be
- * 2 instead of one when re-installing the old package, and 3 when
- * erasing the new package.
- *
- * Another wrinkle is we only want to make this adjustement
- * if the thing we are rollback was an upgrade of package. A pure
- * install or erase does not need the adjustment
- */
- if (se && se->installed &&
- !se->erased &&
- (se->te_types & (TR_ADDED|TR_REMOVED)))
- psm->npkgs_installed--;
- }
- }
-
if (psm->goal == PSM_PKGINSTALL) {
int fc = rpmfiFC(fi);
rc = rpmdbAdd(rpmtsGetRdb(ts), rpmtsGetTid(ts), fi->h,
NULL, NULL);
- /* Set the database instance so consumers (i.e. rpmtsRun())
- * can add this to a rollback transaction.
- */
- rpmteSetDBInstance(psm->te, myinstall_instance);
-
- /*
- * If the score exists and this is not a rollback or autorollback
- * then lets check off installed for this package.
- */
- if (rpmtsGetScore(ts) != NULL &&
- rpmtsGetType(ts) != RPMTRANS_TYPE_ROLLBACK &&
- rpmtsGetType(ts) != RPMTRANS_TYPE_AUTOROLLBACK)
- {
- /* Get the score, if its not NULL, get the appropriate
- * score entry.
- */
- rpmtsScore score = rpmtsGetScore(ts);
- if (score != NULL) {
- rpmtsScoreEntry se;
- /* OK, we got a real score so lets get the appropriate
- * score entry.
- */
- rpmlog(RPMLOG_DEBUG,
- "Attempting to mark %s as installed in score board(%p).\n",
- rpmteN(psm->te), score);
- se = rpmtsScoreGetEntry(score, rpmteN(psm->te));
- if (se != NULL) se->installed = 1;
- }
- }
(void) rpmswExit(rpmtsOp(ts, RPMTS_OP_DBADD), 0);
break;
case PSM_RPMDB_REMOVE:
(void) rpmswEnter(rpmtsOp(ts, RPMTS_OP_DBREMOVE), 0);
rc = rpmdbRemove(rpmtsGetRdb(ts), rpmtsGetTid(ts), fi->record,
NULL, NULL);
-
- /*
- * If the score exists and this is not a rollback or autorollback
- * then lets check off erased for this package.
- */
- if (rpmtsGetScore(ts) != NULL &&
- rpmtsGetType(ts) != RPMTRANS_TYPE_ROLLBACK &&
- rpmtsGetType(ts) != RPMTRANS_TYPE_AUTOROLLBACK)
- {
- /* Get the score, if its not NULL, get the appropriate
- * score entry.
- */
- rpmtsScore score = rpmtsGetScore(ts);
-
- if (score != NULL) { /* XXX: Can't happen */
- rpmtsScoreEntry se;
- /* OK, we got a real score so lets get the appropriate
- * score entry.
- */
- rpmlog(RPMLOG_DEBUG,
- "Attempting to mark %s as erased in score board(%p).\n",
- rpmteN(psm->te), score);
- se = rpmtsScoreGetEntry(score, rpmteN(psm->te));
- if (se != NULL) se->erased = 1;
- }
- }
-
(void) rpmswExit(rpmtsOp(ts, RPMTS_OP_DBREMOVE), 0);
break;
if (_rpmts_stats)
rpmtsPrintStats(ts);
- /* Free up the memory used by the rpmtsScore */
- ts->score = rpmtsScoreFree(ts->score);
-
(void) rpmtsUnlink(ts, RPMDBG_M("tsCreate"));
ts = _free(ts);
return ovsflags;
}
-/*
- * This allows us to mark transactions as being of a certain type.
- * The three types are:
- *
- * RPM_TRANS_NORMAL
- * RPM_TRANS_ROLLBACK
- * RPM_TRANS_AUTOROLLBACK
- *
- * ROLLBACK and AUTOROLLBACK transactions should always be ran as
- * a best effort. In particular this is important to the autorollback
- * feature to avoid rolling back a rollback (otherwise known as
- * dueling rollbacks (-;). AUTOROLLBACK's additionally need instance
- * counts passed to scriptlets to be altered.
- */
-void rpmtsSetType(rpmts ts, rpmtsType type)
-{
- if (ts != NULL) {
- ts->type = type;
- }
-}
-
-/* Let them know what type of transaction we are */
-rpmtsType rpmtsGetType(rpmts ts)
-{
- if (ts != NULL)
- return ts->type;
- else
- return 0;
-}
-
int rpmtsUnorderedSuccessors(rpmts ts, int first)
{
int unorderedSuccessors = 0;
ts = xcalloc(1, sizeof(*ts));
memset(&ts->ops, 0, sizeof(ts->ops));
(void) rpmswEnter(rpmtsOp(ts, RPMTS_OP_TOTAL), -1);
- ts->type = RPMTRANS_TYPE_NORMAL;
ts->filesystemCount = 0;
ts->filesystems = NULL;
ts->dsi = NULL;
memset(ts->pksignid, 0, sizeof(ts->pksignid));
ts->dig = NULL;
- /*
- * We only use the score in an autorollback. So set this to
- * NULL by default.
- */
- ts->score = NULL;
-
ts->nrefs = 0;
return rpmtsLink(ts, RPMDBG_M("tsCreate"));
}
-/**********************
- * Transaction Scores *
- **********************/
-
-
-rpmRC rpmtsScoreInit(rpmts runningTS, rpmts rollbackTS)
-{
- rpmtsScore score;
- rpmtsi pi;
- rpmte p;
- int i;
- int tranElements; /* Number of transaction elements in runningTS */
- int found = 0;
- rpmRC rc = RPMRC_OK; /* Assume success */
- rpmtsScoreEntry se;
-
- rpmlog(RPMLOG_DEBUG, "Creating transaction score board(%p, %p)\n",
- runningTS, rollbackTS);
-
- /* Allocate space for score board */
- score = xcalloc(1, sizeof(*score));
- rpmlog(RPMLOG_DEBUG, "\tScore board address: %p\n", score);
-
- /*
- * Determine the maximum size needed for the entry list.
- * XXX: Today, I just get the count of rpmts elements, and allocate
- * an array that big. Yes this is guaranteed to waste memory.
- * Future updates will hopefully make this more efficient,
- * but for now it will work.
- */
- tranElements = rpmtsNElements(runningTS);
- rpmlog(RPMLOG_DEBUG, "\tAllocating space for %d entries\n", tranElements);
- score->scores = xcalloc(tranElements, sizeof(score->scores));
-
- /* Initialize score entry count */
- score->entries = 0;
- score->nrefs = 0;
-
- /*
- * Increment through transaction elements and make sure for every
- * N there is an rpmtsScoreEntry.
- */
- pi = rpmtsiInit(runningTS);
- while ((p = rpmtsiNext(pi, TR_ADDED|TR_REMOVED)) != NULL) {
- found = 0;
-
- /* Try to find the entry in the score list */
- for(i = 0; i < score->entries; i++) {
- se = score->scores[i];
- if (strcmp(rpmteN(p), se->N) == 0) {
- found = 1;
- break;
- }
- }
-
- /* If we did not find the entry then allocate space for it */
- if (!found) {
-/* XXX p->fi->te undefined. */
- rpmlog(RPMLOG_DEBUG, "\tAdding entry for %s to score board.\n",
- rpmteN(p));
- se = xcalloc(1, sizeof(*(*(score->scores))));
- rpmlog(RPMLOG_DEBUG, "\t\tEntry address: %p\n", se);
- se->N = xstrdup(rpmteN(p));
- se->te_types = rpmteType(p);
- se->installed = 0;
- se->erased = 0;
- score->scores[score->entries] = se;
- score->entries++;
- } else {
- /* We found this one, so just add the element type to the one
- * already there.
- */
- rpmlog(RPMLOG_DEBUG, "\tUpdating entry for %s in score board.\n",
- rpmteN(p));
- score->scores[i]->te_types |= rpmteType(p);
- }
-
- }
- pi = rpmtsiFree(pi);
-
- /*
- * Attach the score to the running transaction and the autorollback
- * transaction.
- */
- runningTS->score = score;
- score->nrefs++;
- rollbackTS->score = score;
- score->nrefs++;
-
- return rc;
-}
-
-rpmtsScore rpmtsScoreFree(rpmtsScore score)
-{
- rpmtsScoreEntry se = NULL;
- int i;
-
- rpmlog(RPMLOG_DEBUG, "May free Score board(%p)\n", score);
-
- /* If score is not initialized, then just return.
- * This is likely the case if autorollbacks are not enabled.
- */
- if (score == NULL) return NULL;
-
- /* Decrement the reference count */
- score->nrefs--;
-
- /* Do we have any more references? If so
- * just return.
- */
- if (score->nrefs > 0) return NULL;
-
- rpmlog(RPMLOG_DEBUG, "\tRefcount is zero...will free\n");
- /* No more references, lets clean up */
- /* First deallocate the score entries */
- for(i = 0; i < score->entries; i++) {
- /* Get the score for the ith entry */
- se = score->scores[i];
-
- /* Deallocate the score entries name */
- se->N = _free(se->N);
-
- /* Deallocate the score entry itself */
- se = _free(se);
- }
-
- /* Next deallocate the score entry table */
- score->scores = _free(score->scores);
-
- /* Finally deallocate the score itself */
- score = _free(score);
-
- return NULL;
-}
-
-/*
- * XXX: Do not get the score and then store it aside for later use.
- * we will delete it out from under you. There is no rpmtsScoreLink()
- * as this may be a very temporary fix for autorollbacks.
- */
-rpmtsScore rpmtsGetScore(rpmts ts)
-{
- if (ts == NULL) return NULL;
- return ts->score;
-}
-
-/*
- * XXX: Do not get the score entry and then store it aside for later use.
- * we will delete it out from under you. There is no
- * rpmtsScoreEntryLink() as this may be a very temporary fix
- * for autorollbacks.
- * XXX: The scores are not sorted. This should be fixed at earliest
- * opportunity (i.e. when we have the whole autorollback working).
- */
-rpmtsScoreEntry rpmtsScoreGetEntry(rpmtsScore score, const char *N)
-{
- int i;
- rpmtsScoreEntry se;
- rpmtsScoreEntry ret = NULL; /* Assume we don't find it */
-
- rpmlog(RPMLOG_DEBUG, "Looking in score board(%p) for %s\n", score, N);
-
- /* Try to find the entry in the score list */
- for(i = 0; i < score->entries; i++) {
- se = score->scores[i];
- if (strcmp(N, se->N) == 0) {
- rpmlog(RPMLOG_DEBUG, "\tFound entry at address: %p\n", se);
- ret = se;
- break;
- }
- }
-
-/* XXX score->scores undefined. */
- return ret;
-}
return fi;
}
-/**
- * This is not a generalized function to be called from outside
- * librpm. It is called internally by rpmtsRun() to rollback
- * a failed transaction.
- * @param rollbackTransaction rollback transaction
- * @return RPMRC_OK, or RPMRC_FAIL
- */
-static rpmRC _rpmtsRollback(rpmts rollbackTransaction)
-{
- int rc = 0;
- int numAdded = 0;
- int numRemoved = 0;
- rpm_tid_t tid;
- rpmtsi tsi;
- rpmte te;
- rpmps ps;
-
- /*
- * Gather information about this rollback transaction for reporting.
- * 1) Get tid
- */
- tid = rpmtsGetTid(rollbackTransaction);
-
- /*
- * 2) Get number of install elments and erase elements
- */
- tsi = rpmtsiInit(rollbackTransaction);
- while((te = rpmtsiNext(tsi, 0)) != NULL) {
- switch (rpmteType(te)) {
- case TR_ADDED:
- numAdded++;
- break;
- case TR_REMOVED:
- numRemoved++;
- break;
- default:
- break;
- }
- }
- tsi = rpmtsiFree(tsi);
-
- rpmlog(RPMLOG_NOTICE, _("Transaction failed...rolling back\n"));
- rpmlog(RPMLOG_NOTICE,
- _("Rollback packages (+%d/-%d) to %-24.24s (0x%08x):\n"),
- numAdded, numRemoved, ctime((time_t*) &tid), tid);
-
- /* Check the transaction to see if it is doable */
- rc = rpmtsCheck(rollbackTransaction);
- ps = rpmtsProblems(rollbackTransaction);
- if (rc != 0 && rpmpsNumProblems(ps) > 0) {
- rpmlog(RPMLOG_ERR, _("Failed dependencies:\n"));
- rpmpsPrint(NULL, ps);
- ps = rpmpsFree(ps);
- return -1;
- }
- ps = rpmpsFree(ps);
-
- /* Order the transaction */
- rc = rpmtsOrder(rollbackTransaction);
- if (rc != 0) {
- rpmlog(RPMLOG_ERR,
- _("Could not order auto-rollback transaction!\n"));
- return -1;
- }
-
-
-
- /* Run the transaction and print any problems
- * We want to stay with the original transactions flags except
- * that we want to add what is essentially a force.
- * This handles two things in particular:
- *
- * 1. We we want to upgrade over a newer package.
- * 2. If a header for the old package is there we
- * we want to replace it. No questions asked.
- */
- rc = rpmtsRun(rollbackTransaction, NULL,
- RPMPROB_FILTER_REPLACEPKG
- | RPMPROB_FILTER_REPLACEOLDFILES
- | RPMPROB_FILTER_REPLACENEWFILES
- | RPMPROB_FILTER_OLDPACKAGE
- );
- ps = rpmtsProblems(rollbackTransaction);
- if (rc > 0 && rpmpsNumProblems(ps) > 0)
- rpmpsPrint(stderr, ps);
- ps = rpmpsFree(ps);
-
- /*
- * After we have ran through the transaction we need to
- * remove any repackaged packages we just installed/upgraded
- * from the rp repository.
- */
- tsi = rpmtsiInit(rollbackTransaction);
- while((te = rpmtsiNext(tsi, 0)) != NULL) {
- fnpyKey key = NULL;
- rpmlog(RPMLOG_NOTICE, _("Cleaning up repackaged packages:\n"));
- switch (rpmteType(te)) {
- /* The install elements are repackaged packages */
- case TR_ADDED:
- /* Make sure the filename is still there. XXX: Can't happen */
- key = rpmteKey(te);
- if(key) {
- rpmlog(RPMLOG_NOTICE, _("\tRemoving %s:\n"), (const char*)key);
- (void) unlink(key); /* XXX: Should check for an error? */
- }
- break;
-
- /* Ignore erase elements...nothing to do */
- default:
- break;
- }
- }
- tsi = rpmtsiFree(tsi);
-
- /* Free the rollback transaction */
- rollbackTransaction = rpmtsFree(rollbackTransaction);
-
- return rc;
-}
-
-/**
- * Get the repackaged header and filename from the repackage directory.
- * @todo Find a suitable home for this function.
- * @todo This function creates an IDTX everytime it is called. Needs to
- * be made more efficient (only create on per running transaction).
- * @param ts rpm transaction
- * @param te transaction element
- * @retval hdrp Repackaged header
- * @retval fnp Repackaged package's path (transaction key)
- * @return RPMRC_NOTFOUND or RPMRC_OK
- */
-static rpmRC getRepackageHeaderFromTE(rpmts ts, rpmte te,
- Header *hdrp,
- const char **fnp)
-{
- rpm_tid_t tid;
- const char * name;
- const char * rpname = NULL;
- const char * _repackage_dir = NULL;
- const char * globStr = "-*.rpm";
- char * rp = NULL; /* Rollback package name */
- IDTX rtids = NULL;
- IDT rpIDT;
- int nrids = 0;
- size_t nb; /* Number of bytes */
- Header h = NULL;
- int rc = RPMRC_NOTFOUND; /* Assume we do not find it*/
- int xx;
-
- rpmlog(RPMLOG_DEBUG,
- "Getting repackaged header from transaction element\n");
-
- /* Set header pointer to null if its not already */
- if (hdrp)
- *hdrp = NULL;
- if (fnp)
- *fnp = NULL;
-
- /* Get the TID of the current transaction */
- tid = rpmtsGetTid(ts);
- /* Need the repackage dir if the user want to
- * rollback on a failure.
- */
- _repackage_dir = rpmExpand("%{?_repackage_dir}", NULL);
- if (_repackage_dir == NULL) goto exit;
-
- /* Build the glob string to find the possible repackaged
- * packages for this package.
- */
- name = rpmteN(te);
- nb = strlen(_repackage_dir) + strlen(name) + strlen(globStr) + 2;
- rp = memset((char *) malloc(nb), 0, nb);
- xx = snprintf(rp, nb, "%s/%s%s.rpm", _repackage_dir, name, globStr);
-
- /* Get the index of possible repackaged packages */
- rpmlog(RPMLOG_DEBUG, "\tLooking for %s...\n", rp);
- rtids = IDTXglob(ts, rp, RPMTAG_REMOVETID);
- rp = _free(rp);
- if (rtids != NULL) {
- rpmlog(RPMLOG_DEBUG, "\tMatches found.\n");
- rpIDT = rtids->idt;
- nrids = rtids->nidt;
- } else {
- rpmlog(RPMLOG_DEBUG, "\tNo matches found.\n");
- goto exit;
- }
-
- /* Now walk through index until we find the package (or we have
- * exhausted the index.
- */
- do {
- /* If index is null we have exhausted the list and need to
- * get out of here...the repackaged package was not found.
- */
- if (rpIDT == NULL) {
- rpmlog(RPMLOG_DEBUG, "\tRepackaged package not found!.\n");
- break;
- }
-
- /* Is this the same tid. If not decrement the list and continue */
- if (rpIDT->val.u32 != tid) {
- nrids--;
- if (nrids > 0)
- rpIDT++;
- else
- rpIDT = NULL;
- continue;
- }
-
- /* OK, the tid matches. Now lets see if the name is the same.
- * If I could not get the name from the package, I will go onto
- * the next one. Perhaps I should return an error at this
- * point, but if this was not the correct one, at least the correct one
- * would be found.
- * XXX: Should Match NAC!
- */
- rpmlog(RPMLOG_DEBUG, "\tREMOVETID matched INSTALLTID.\n");
- if (headerGetEntry(rpIDT->h, RPMTAG_NAME, NULL, (rpm_data_t *) &rpname, NULL)) {
- rpmlog(RPMLOG_DEBUG, "\t\tName: %s.\n", rpname);
- if (!strcmp(name,rpname)) {
- /* It matched we have a canidate */
- h = headerLink(rpIDT->h);
- nb = strlen(rpIDT->key) + 1;
- rp = memset((char *) malloc(nb), 0, nb);
- rp = strncat(rp, rpIDT->key, nb);
- rc = RPMRC_OK;
- break;
- }
- }
-
- /* Decrement list */
- nrids--;
- if (nrids > 0)
- rpIDT++;
- else
- rpIDT = NULL;
- } while (1);
-
-exit:
- if (rc != RPMRC_NOTFOUND && h != NULL && hdrp != NULL) {
- rpmlog(RPMLOG_DEBUG, "\tRepackaged Package was %s...\n", rp);
- if (hdrp != NULL)
- *hdrp = headerLink(h);
- if (fnp != NULL)
- *fnp = rp;
- else
- rp = _free(rp);
- }
- if (h != NULL)
- h = headerFree(h);
- rtids = IDTXfree(rtids);
- return rc;
-}
-
-/**
- * This is not a generalized function to be called from outside
- * librpm. It is called internally by rpmtsRun() to add elements
- * to its autorollback transaction.
- * @param rollbackTransaction rollback transaction
- * @param runningTransaction running transaction (the one you want to rollback)
- * @param te Transaction element.
- * @return RPMRC_OK, or RPMRC_FAIL
- */
-static rpmRC _rpmtsAddRollbackElement(rpmts rollbackTransaction,
- rpmts runningTransaction, rpmte te)
-{
- Header h = NULL;
- Header rph = NULL;
- const char * rpn;
- unsigned int db_instance = 0;
- rpmtsi pi;
- rpmte p;
- int rc = RPMRC_FAIL; /* Assume Failure */
-
- switch(rpmteType(te)) {
- case TR_ADDED:
- { rpmdbMatchIterator mi;
-
- rpmlog(RPMLOG_DEBUG,
- "Adding install element to auto-rollback transaction.\n");
-
- /* Get the header for this package from the database
- * First get the database instance (the key).
- */
- db_instance = rpmteDBInstance(te);
- if (db_instance == 0) {
- /* Could not get the db instance: WTD! */
- rpmlog(RPMLOG_CRIT,
- _("Could not get install element database instance!\n"));
- break;
- }
-
- /* Now suck the header out of the database */
- mi = rpmtsInitIterator(rollbackTransaction,
- RPMDBI_PACKAGES, &db_instance, sizeof(db_instance));
- h = rpmdbNextIterator(mi);
- if (h != NULL) h = headerLink(h);
- mi = rpmdbFreeIterator(mi);
- if (h == NULL) {
- /* Header was not there??? */
- rpmlog(RPMLOG_CRIT,
- _("Could not get header for auto-rollback transaction!\n"));
- break;
- }
-
- /* Now see if there is a repackaged package for this */
- rc = getRepackageHeaderFromTE(runningTransaction, te, &rph, &rpn);
- switch(rc) {
- case RPMRC_OK:
- /* Add the install element, as we had a repackaged package */
- rpmlog(RPMLOG_DEBUG,
- "\tAdded repackaged package header: %s.\n", rpn);
- rpmlog(RPMLOG_DEBUG,
- "\tAdded from install element %s.\n", rpmteNEVRA(te));
- rc = rpmtsAddInstallElement(rollbackTransaction, headerLink(rph),
- (fnpyKey) rpn, 1, te->relocs);
- break;
-
- case RPMRC_NOTFOUND:
- /* Add the header as an erase element, we did not
- * have a repackaged package
- */
- rpmlog(RPMLOG_DEBUG, "\tAdded erase element.\n");
- rpmlog(RPMLOG_DEBUG,
- _("\tAdded from install element %s.\n"), rpmteNEVRA(te));
- rc = rpmtsAddEraseElement(rollbackTransaction, h, db_instance);
- break;
-
- default:
- /* Not sure what to do on failure...just give up */
- rpmlog(RPMLOG_CRIT,
- _("Could not get repackaged header for auto-rollback transaction!\n"));
- break;
- }
- } break;
-
- case TR_REMOVED:
- rpmlog(RPMLOG_DEBUG,
- "Add erase element to auto-rollback transaction.\n");
- /* See if this element has already been added.
- * If so we want to do nothing. Compare N's for match.
- * XXX: Really should compare NAC's.
- */
- pi = rpmtsiInit(rollbackTransaction);
- while ((p = rpmtsiNext(pi, 0)) != NULL) {
- if (!strcmp(rpmteN(p), rpmteN(te))) {
- rpmlog(RPMLOG_DEBUG, "\tFound existing upgrade element.\n");
- rpmlog(RPMLOG_DEBUG, "\tNot adding erase element for %s.\n",
- rpmteN(te));
- rc = RPMRC_OK;
- pi = rpmtsiFree(pi);
- goto cleanup;
- }
- }
- pi = rpmtsiFree(pi);
-
- /* Get the repackage header from the current transaction
- * element.
- */
- rc = getRepackageHeaderFromTE(runningTransaction, te, &rph, &rpn);
- switch(rc) {
- case RPMRC_OK:
- /* Add the install element */
- rpmlog(RPMLOG_DEBUG,
- "\tAdded repackaged package %s.\n", rpn);
- rpmlog(RPMLOG_DEBUG,
- "\tAdded from erase element %s.\n", rpmteNEVRA(te));
- rc = rpmtsAddInstallElement(rollbackTransaction, rph,
- (fnpyKey) rpn, 1, te->relocs);
- if (rc != RPMRC_OK)
- rpmlog(RPMLOG_CRIT,
- _("Could not add erase element to auto-rollback transaction.\n"));
- break;
-
- case RPMRC_NOTFOUND:
- /* Just did not have a repackaged package */
- rpmlog(RPMLOG_DEBUG,
- "\tNo repackaged package...nothing to do.\n");
- rc = RPMRC_OK;
- break;
-
- default:
- rpmlog(RPMLOG_CRIT,
- _("Failure reading repackaged package!\n"));
- break;
- }
- break;
-
- default:
- break;
- }
-
-/* XXX: I want to free this, but if I do then the consumers of
- * are hosed. Just leaving you a little note Jeff, so you
- * know that this does introduce a memory leak. I wanted
- * keep the patch as simple as possible so I am not fixxing
- * the leak.
- * if (rpn != NULL)
- * free(rpn);
- */
-
-cleanup:
- /* Clean up */
- if (h != NULL)
- h = headerFree(h);
- if (rph != NULL)
- rph = headerFree(rph);
- return rc;
-}
-
#define NOTIFY(_ts, _al) if ((_ts)->notify) (void) (_ts)->notify _al
int rpmtsRun(rpmts ts, rpmps okProbs, rpmprobFilterFlags ignoreSet)
rpmtsi qi; rpmte q;
int numAdded;
int numRemoved;
- rpmts rollbackTransaction = NULL;
- int rollbackOnFailure = 0;
void * lock = NULL;
int xx;
if (rpmtsNElements(ts) <= 0)
return -1;
- /* See if we need to rollback on failure */
- rollbackOnFailure = rpmExpandNumeric(
- "%{?_rollback_transaction_on_failure}");
- if (rpmtsGetType(ts) & (RPMTRANS_TYPE_ROLLBACK
- | RPMTRANS_TYPE_AUTOROLLBACK)) {
- rollbackOnFailure = 0;
- }
- /* If we are in test mode, there is no need to rollback on
- * failure, nor acquire the transaction lock.
- */
/* If we are in test mode, then there's no need for transaction lock. */
- if (rpmtsFlags(ts) & RPMTRANS_FLAG_TEST) {
- rollbackOnFailure = 0;
- } else {
+ if (!(rpmtsFlags(ts) & RPMTRANS_FLAG_TEST)) {
lock = rpmtsAcquireLock(ts);
if (lock == NULL)
return -1; /* XXX W2DO? */
}
/* ===============================================
- * If we were requested to rollback this transaction
- * if an error occurs, then we need to create a
- * a rollback transaction.
- */
- if (rollbackOnFailure) {
- rpmtransFlags tsFlags;
- rpmVSFlags ovsflags;
- rpmVSFlags vsflags;
-
- rpmlog(RPMLOG_DEBUG,
- "Creating auto-rollback transaction\n");
-
- rollbackTransaction = rpmtsCreate();
-
- /* Set the verify signature flags:
- * - can't verify digests on repackaged packages. Other than
- * they are wrong, this will cause segfaults down stream.
- * - signatures are out too.
- * - header check are out.
- */
- vsflags = rpmExpandNumeric("%{?_vsflags_erase}");
- vsflags |= _RPMVSF_NODIGESTS;
- vsflags |= _RPMVSF_NOSIGNATURES;
- vsflags |= RPMVSF_NOHDRCHK;
- vsflags |= RPMVSF_NEEDPAYLOAD; /* XXX no legacy signatures */
- ovsflags = rpmtsSetVSFlags(ts, vsflags);
-
- /*
- * If we run this thing its imperitive that it be known that it
- * is an autorollback transaction. This will affect the instance
- * counts passed to the scriptlets in the psm.
- */
- rpmtsSetType(rollbackTransaction, RPMTRANS_TYPE_AUTOROLLBACK);
-
- /* Set transaction flags to be the same as the running transaction */
- tsFlags = rpmtsSetFlags(rollbackTransaction, rpmtsFlags(ts));
-
- /* Set root dir to be the same as the running transaction */
- rpmtsSetRootDir(rollbackTransaction, rpmtsRootDir(ts));
-
- /* Setup the notify of the call back to be the same as the running
- * transaction
- */
- xx = rpmtsSetNotifyCallback(rollbackTransaction, ts->notify, ts->notifyData);
-
- /* Create rpmtsScore for running transaction and rollback transaction */
- xx = rpmtsScoreInit(ts, rollbackTransaction);
- }
-
- /* ===============================================
* Save removed files before erasing.
*/
if (rpmtsFlags(ts) & (RPMTRANS_FLAG_DIRSTASH | RPMTRANS_FLAG_REPACKAGE)) {
rpmteKey(p), ts->notifyData);
p->fd = NULL;
ourrc++;
-
- /* If we should rollback this transaction
- on failure, lets do it. */
- if (rollbackOnFailure) {
- rpmlog(RPMLOG_ERR,
- _("Add failed. Could not read package header.\n"));
- /* Clean up the current transaction */
- p->h = headerFree(p->h);
- xx = rpmdbSync(rpmtsGetRdb(ts));
- psm = rpmpsmFree(psm);
- p->fi = rpmfiFree(p->fi);
- pi = rpmtsiFree(pi);
-
- /* Run the rollback transaction */
- xx = _rpmtsRollback(rollbackTransaction);
- return -1;
- }
break;
case RPMRC_NOTTRUSTED:
case RPMRC_NOKEY:
if (rpmpsmStage(psm, PSM_PKGINSTALL)) {
ourrc++;
lastFailKey = pkgKey;
-
- /* If we should rollback this transaction
- on failure, lets do it. */
- if (rollbackOnFailure) {
- rpmlog(RPMLOG_ERR,
- _("Add failed in rpmpsmStage().\n"));
- /* Clean up the current transaction */
- p->h = headerFree(p->h);
- xx = rpmdbSync(rpmtsGetRdb(ts));
- psm = rpmpsmFree(psm);
- p->fi = rpmfiFree(p->fi);
- pi = rpmtsiFree(pi);
-
- /* Run the rollback transaction */
- xx = _rpmtsRollback(rollbackTransaction);
- return -1;
- }
}
- /* If we should rollback on failure lets add
- * this element to the rollback transaction
- * as an erase element as it has installed succesfully.
- */
- if (rollbackOnFailure) {
- int rc;
-
- rc = _rpmtsAddRollbackElement(rollbackTransaction, ts, p);
- if (rc != RPMRC_OK) {
- /* Clean up the current transaction */
- p->h = headerFree(p->h);
- xx = rpmdbSync(rpmtsGetRdb(ts));
- psm = rpmpsmFree(psm);
- p->fi = rpmfiFree(p->fi);
- pi = rpmtsiFree(pi);
-
- /* Clean up rollback transaction */
- rollbackTransaction = rpmtsFree(rollbackTransaction);
- return -1;
- }
- }
} else {
ourrc++;
lastFailKey = pkgKey;
-
- /* If we should rollback this transaction
- * on failure, lets do it.
- */
- if (rollbackOnFailure) {
- rpmlog(RPMLOG_ERR, _("Add failed. Could not get file list.\n"));
- /* Clean up the current transaction */
- p->h = headerFree(p->h);
- xx = rpmdbSync(rpmtsGetRdb(ts));
- psm = rpmpsmFree(psm);
- p->fi = rpmfiFree(p->fi);
- pi = rpmtsiFree(pi);
-
- /* Run the rollback transaction */
- xx = _rpmtsRollback(rollbackTransaction);
- return -1;
- }
}
if (gotfd) {
if (rpmteDependsOnKey(p) != lastFailKey) {
if (rpmpsmStage(psm, PSM_PKGERASE)) {
ourrc++;
-
- /* If we should rollback this transaction
- * on failure, lets do it.
- */
- if (rollbackOnFailure) {
- rpmlog(RPMLOG_ERR,
- _("Erase failed failed in rpmpsmStage().\n"));
- /* Clean up the current transaction */
- xx = rpmdbSync(rpmtsGetRdb(ts));
- psm = rpmpsmFree(psm);
- p->fi = rpmfiFree(p->fi);
- pi = rpmtsiFree(pi);
-
- /* Run the rollback transaction */
- xx = _rpmtsRollback(rollbackTransaction);
- return -1;
- }
- }
-
- /* If we should rollback on failure lets add
- * this element to the rollback transaction
- * as an install element as it has erased succesfully.
- */
- if (rollbackOnFailure) {
- int rc;
-
- rc = _rpmtsAddRollbackElement(rollbackTransaction, ts, p);
-
- if (rc != RPMRC_OK) {
- /* Clean up the current transaction */
- xx = rpmdbSync(rpmtsGetRdb(ts));
- psm = rpmpsmFree(psm);
- p->fi = rpmfiFree(p->fi);
- pi = rpmtsiFree(pi);
-
- /* Clean up rollback transaction */
- rollbackTransaction = rpmtsFree(rollbackTransaction);
- return -1;
- }
}
}
}
pi = rpmtsiFree(pi);
- /* If we created a rollback transaction lets get rid of it */
- if (rollbackOnFailure && rollbackTransaction != NULL)
- rollbackTransaction = rpmtsFree(rollbackTransaction);
-
if (!(rpmtsFlags(ts) & RPMTRANS_FLAG_TEST)) {
rpmlog(RPMLOG_DEBUG, "running post-transaction scripts\n");
pi = rpmtsiInit(ts);
projects / tools / librpm-tizen.git / commitdiff