rfkill: use DEFINE_SPINLOCK() for spinlock
authorGuobin Huang <huangguobin4@huawei.com>
Tue, 6 Apr 2021 12:11:56 +0000 (20:11 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 8 Apr 2021 08:16:53 +0000 (10:16 +0200)
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
Link: https://lore.kernel.org/r/1617711116-49370-1-git-send-email-huangguobin4@huawei.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/rfkill/input.c

index 4b01baea1d4ac59b3c6ef9f3c8960567b64dc48e..598d0a61bda7751b02c3cb45d6fcecaf2c4317fb 100644 (file)
@@ -36,7 +36,7 @@ module_param_named(master_switch_mode, rfkill_master_switch_mode, uint, 0);
 MODULE_PARM_DESC(master_switch_mode,
        "SW_RFKILL_ALL ON should: 0=do nothing (only unlock); 1=restore; 2=unblock all");
 
-static spinlock_t rfkill_op_lock;
+static DEFINE_SPINLOCK(rfkill_op_lock);
 static bool rfkill_op_pending;
 static unsigned long rfkill_sw_pending[BITS_TO_LONGS(NUM_RFKILL_TYPES)];
 static unsigned long rfkill_sw_state[BITS_TO_LONGS(NUM_RFKILL_TYPES)];
@@ -330,8 +330,6 @@ int __init rfkill_handler_init(void)
                return -EINVAL;
        }
 
-       spin_lock_init(&rfkill_op_lock);
-
        /* Avoid delay at first schedule */
        rfkill_last_scheduled =
                        jiffies - msecs_to_jiffies(RFKILL_OPS_DELAY) - 1;