drm/i915/selftests: Always call the provided engine->emit_init_breadcrumb
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 13 May 2020 07:48:01 +0000 (08:48 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 14 May 2020 08:01:54 +0000 (09:01 +0100)
While this does not appear to fix any issues, the backend itself knows
when it wants to emit a breadcrumb, so let it make the final call.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200513074809.18194-16-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/selftests/i915_perf.c
drivers/gpu/drm/i915/selftests/igt_spinner.c

index 5608fab..ca0c9db 100644 (file)
@@ -221,8 +221,7 @@ static int live_noa_delay(void *arg)
                goto out;
        }
 
-       if (rq->engine->emit_init_breadcrumb &&
-           i915_request_timeline(rq)->has_initial_breadcrumb) {
+       if (rq->engine->emit_init_breadcrumb) {
                err = rq->engine->emit_init_breadcrumb(rq);
                if (err) {
                        i915_request_add(rq);
index 9ad4ab0..e35ba5f 100644 (file)
@@ -169,8 +169,7 @@ igt_spinner_create_request(struct igt_spinner *spin,
 
        intel_gt_chipset_flush(engine->gt);
 
-       if (engine->emit_init_breadcrumb &&
-           i915_request_timeline(rq)->has_initial_breadcrumb) {
+       if (engine->emit_init_breadcrumb) {
                err = engine->emit_init_breadcrumb(rq);
                if (err)
                        goto cancel_rq;