Fix memory leak on custom code

* The result of xmlGetProp() should be free.
* See, http://xmlsoft.org/library.html

* It is different with below commit on tizen branch
* [c8d86331b65b3c290e7a1b3de7092d3a5a00b468]

Change-Id: Iffb19e18f45b1ac51acb70c22e279f709cad3751
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>

diff --git a/src/xmldsig.c b/src/xmldsig.c
index db33058..19973d4 100644 (file)
--- a/src/xmldsig.c
+++ b/src/xmldsig.c
@@ -980,21 +980,21 @@ xmlSecDSigCtxProcessReferences(xmlSecDSigCtxPtr dsigCtx, xmlNodePtr firstReferen
                     return(-1);
                 }
 
-                xmlSecError(XMLSEC_ERRORS_HERE,
-                            NULL,
-                            NULL,
-                            XMLSEC_ERRORS_MAX_NUMBER,
-                            "Start to search reference on proxy : %s.",
-                            refUri);
-
                 xmlSecProxyCtxPtr pc = dsigCtx->proxyCtxPtr;
                 while(pc != NULL) {
                     if(xmlSecDecodeCmp(refUri, pc->cache) == 0) {
                         isInProxy = 1;
+                        xmlSecError(XMLSEC_ERRORS_HERE,
+                                    NULL,
+                                    NULL,
+                                    XMLSEC_ERRORS_MAX_NUMBER,
+                                    "Check [%s] on processing references.",
+                                    refUri);
                         break;
                     }
                     pc = pc->next;
                 }
+                xmlFree(refUri);
             } else {
                 /* if proxy is not exist, process references */
                 xmlSecError(XMLSEC_ERRORS_HERE,
@@ -1002,19 +1002,11 @@ xmlSecDSigCtxProcessReferences(xmlSecDSigCtxPtr dsigCtx, xmlNodePtr firstReferen
                             NULL,
                             XMLSEC_ERRORS_MAX_NUMBER,
                             "Proxy doesn't exist.");
-                isInProxy = 1;
             }
 
             /* if not exist on proxy, skip on processing references */
-            if(isInProxy == 0) {
-                xmlSecError(XMLSEC_ERRORS_HERE,
-                            NULL,
-                            NULL,
-                            XMLSEC_ERRORS_MAX_NUMBER,
-                            "Skip %s on processing references.",
-                            xmlGetProp(cur, xmlSecAttrURI));
+            if(isInProxy == 0)
                 continue;
-            }
         }
 
         /* create reference */